Minor fixes to spellcheck_test

Minor fixes to spellcheck_test

This patch fixes some minor issues in spellcheck_test:

1. For each spellcheck_test, the creation of its |Test| object is advanced
to prevent testharness from terminating too early.

2. Even if a test fails, its sample is still removed as long as we are
running tests, so that its sample does not affect visibility of other
tests. This reduces flakiness with idle time spell checker tests because
it relies on visibility.

3. When a test finishes, |spellcheckTestRunning| is set back to |false|
after the test's callback is run. This prevents two tests from running
in parallel.

This patch is also a preparation for crrev.com/2590823006.

BUG=674819
Committed: https://crrev.com/2637c3534065de0f8271f185272543211d690113
Cr-Commit-Position: refs/heads/master@{#440049}

[Xiaocheng, 2016-12-21 06:48:47]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 06:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-12-21 07:30:25]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-12-21 07:30:25]

PTAL.

[tkent, 2016-12-21 07:33:29]

lgtm

[Xiaocheng, 2016-12-21 07:59:07]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2016-12-21 07:59:10]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-12-21 07:59:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 08:06:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482307150246040, "parent_rev":
"e2fb22a6a4b5c90372e410567f288836eb37ff7f", "commit_rev":
"8990522057cab68ed8dd53184ba6505265ac87ab"}

[commit-bot: I haz the power, 2016-12-21 08:07:11]

Description was changed from

==========
Minor fixes to spellcheck_test

This patch fixes some minor issues in spellcheck_test:

1. For each spellcheck_test, the creation of its |Test| object is advanced
to prevent testharness from terminating too early.

2. Even if a test fails, its sample is still removed as long as we are
running tests, so that its sample does not affect visibility of other
tests. This reduces flakiness with idle time spell checker tests because
it relies on visibility.

3. When a test finishes, |spellcheckTestRunning| is set back to |false|
after the test's callback is run. This prevents two tests from running
in parallel.

This patch is also a preparation for crrev.com/2590823006.

BUG=674819
==========

to

==========
Minor fixes to spellcheck_test

This patch fixes some minor issues in spellcheck_test:

1. For each spellcheck_test, the creation of its |Test| object is advanced
to prevent testharness from terminating too early.

2. Even if a test fails, its sample is still removed as long as we are
running tests, so that its sample does not affect visibility of other
tests. This reduces flakiness with idle time spell checker tests because
it relies on visibility.

3. When a test finishes, |spellcheckTestRunning| is set back to |false|
after the test's callback is run. This prevents two tests from running
in parallel.

This patch is also a preparation for crrev.com/2590823006.

BUG=674819

Review-Url: https://codereview.chromium.org/2591023003
==========

[commit-bot: I haz the power, 2016-12-21 08:07:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 08:11:06]

Description was changed from

==========
Minor fixes to spellcheck_test

This patch fixes some minor issues in spellcheck_test:

1. For each spellcheck_test, the creation of its |Test| object is advanced
to prevent testharness from terminating too early.

2. Even if a test fails, its sample is still removed as long as we are
running tests, so that its sample does not affect visibility of other
tests. This reduces flakiness with idle time spell checker tests because
it relies on visibility.

3. When a test finishes, |spellcheckTestRunning| is set back to |false|
after the test's callback is run. This prevents two tests from running
in parallel.

This patch is also a preparation for crrev.com/2590823006.

BUG=674819

Review-Url: https://codereview.chromium.org/2591023003
==========

to

==========
Minor fixes to spellcheck_test

This patch fixes some minor issues in spellcheck_test:

1. For each spellcheck_test, the creation of its |Test| object is advanced
to prevent testharness from terminating too early.

2. Even if a test fails, its sample is still removed as long as we are
running tests, so that its sample does not affect visibility of other
tests. This reduces flakiness with idle time spell checker tests because
it relies on visibility.

3. When a test finishes, |spellcheckTestRunning| is set back to |false|
after the test's callback is run. This prevents two tests from running
in parallel.

This patch is also a preparation for crrev.com/2590823006.

BUG=674819

Committed: https://crrev.com/2637c3534065de0f8271f185272543211d690113
Cr-Commit-Position: refs/heads/master@{#440049}
==========

[commit-bot: I haz the power, 2016-12-21 08:11:07]

Patchset 1 (id:??) landed as
https://crrev.com/2637c3534065de0f8271f185272543211d690113
Cr-Commit-Position: refs/heads/master@{#440049}