Remove input/source components from AudioDestination

Remove input/source components from AudioDestination

Based on the comment in the code and the investigation around it, we do
not use sourceData meaningfully in the code. Considering the live input
is done by gUM, we can safely remove this from the render call chain.

This is the first part of refactoring/clean up of AudioDestination to
support the new threading model of AudioWorkletNode.

BUG=675988
TEST=

Committed: https://crrev.com/1b679d7ce7918dd41e68e1170c7f6dfd4edcc4bd
Cr-Commit-Position: refs/heads/master@{#440126}

[hongchan, 2016-12-20 20:38:33]

hongchan@chromium.org changed reviewers:
+ olka@chromium.org, rtoy@chromium.org

[hongchan, 2016-12-20 20:38:34]

PTAL.

olka@ - content/media/renderer/*

rtoy@ - webaudio

[Raymond Toy, 2016-12-20 21:46:49]

https://codereview.chromium.org/2590983003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/AudioDestination.cpp (right):

https://codereview.chromium.org/2590983003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/AudioDestination.cpp:209:
m_callback.render(nullptr, bus, framesToProcess, outputPosition);
Can this be updated to remove the first arg?

[hongchan, 2016-12-20 21:58:36]

On 2016/12/20 21:46:49, Raymond Toy wrote:
>
https://codereview.chromium.org/2590983003/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/audio/AudioDestination.cpp (right):
> 
>
https://codereview.chromium.org/2590983003/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/audio/AudioDestination.cpp:209:
> m_callback.render(nullptr, bus, framesToProcess, outputPosition);
> Can this be updated to remove the first arg?

Certainly, but I would like to address that in the follow-up CL. This changes
the shape of the render call chain in *DestinationNode and AudioSourceProvider.

[Raymond Toy, 2016-12-20 21:59:59]

lgtm for webaudio

[DaleCurtis, 2016-12-20 22:02:04]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-12-20 22:02:05]

olka's ooo, so media/ lgtm  - thanks for cleaning this up!

[hongchan, 2016-12-20 22:03:22]

The CQ bit was checked by hongchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 22:04:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:02:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:02:50]

Dry run: This issue passed the CQ dry run.

[hongchan, 2016-12-21 00:17:23]

The CQ bit was checked by hongchan@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:17:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:28:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:28:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hongchan, 2016-12-21 16:09:24]

hongchan@chromium.org changed reviewers:
+ haraken@chromium.org
- olka@chromium.org

[hongchan, 2016-12-21 16:09:25]

haraken@ 

Please review changes in */platform/*

[haraken, 2016-12-21 16:30:22]

LGTM

[hongchan, 2016-12-21 16:32:24]

The CQ bit was checked by hongchan@chromium.org

[commit-bot: I haz the power, 2016-12-21 16:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 16:38:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482337944499500, "parent_rev":
"3719f30de87b838c58310b5007dfef7eb239b4ed", "commit_rev":
"0e17e20e3f7b996eac0f76bf80e769c64b0afbe1"}

[commit-bot: I haz the power, 2016-12-21 16:38:50]

Description was changed from

==========
Remove input/source components from AudioDestination

Based on the comment in the code and the investigation around it, we do
not use sourceData meaningfully in the code. Considering the live input
is done by gUM, we can safely remove this from the render call chain.

This is the first part of refactoring/clean up of AudioDestination to
support the new threading model of AudioWorkletNode.

BUG=675988
TEST=
==========

to

==========
Remove input/source components from AudioDestination

Based on the comment in the code and the investigation around it, we do
not use sourceData meaningfully in the code. Considering the live input
is done by gUM, we can safely remove this from the render call chain.

This is the first part of refactoring/clean up of AudioDestination to
support the new threading model of AudioWorkletNode.

BUG=675988
TEST=

Review-Url: https://codereview.chromium.org/2590983003
==========

[commit-bot: I haz the power, 2016-12-21 16:38:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 16:42:59]

Description was changed from

==========
Remove input/source components from AudioDestination

Based on the comment in the code and the investigation around it, we do
not use sourceData meaningfully in the code. Considering the live input
is done by gUM, we can safely remove this from the render call chain.

This is the first part of refactoring/clean up of AudioDestination to
support the new threading model of AudioWorkletNode.

BUG=675988
TEST=

Review-Url: https://codereview.chromium.org/2590983003
==========

to

==========
Remove input/source components from AudioDestination

Based on the comment in the code and the investigation around it, we do
not use sourceData meaningfully in the code. Considering the live input
is done by gUM, we can safely remove this from the render call chain.

This is the first part of refactoring/clean up of AudioDestination to
support the new threading model of AudioWorkletNode.

BUG=675988
TEST=

Committed: https://crrev.com/1b679d7ce7918dd41e68e1170c7f6dfd4edcc4bd
Cr-Commit-Position: refs/heads/master@{#440126}
==========

[commit-bot: I haz the power, 2016-12-21 16:43:00]

Patchset 1 (id:??) landed as
https://crrev.com/1b679d7ce7918dd41e68e1170c7f6dfd4edcc4bd
Cr-Commit-Position: refs/heads/master@{#440126}