Removes two unnecessary cells + adds missing unit test for an existing cell

Removes two unnecessary cells + adds missing unit test for an existing cell.

BUG=602666
Committed: https://crrev.com/398d9f24b61c285c532d91d98d649fe6d563373d
Cr-Commit-Position: refs/heads/master@{#439847}

[Moe, 2016-12-20 15:35:12]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 15:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-12-20 15:35:36]

mahmadi@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Moe, 2016-12-20 15:35:36]

Hi Justin, Please review this CL.

[Justin Donnelly, 2016-12-20 15:44:23]

lgtm with a nit (please add a period to the end of the CL title and description)
and a question.

https://codereview.chromium.org/2590943002/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_items_display_view_controller.mm
(right):

https://codereview.chromium.org/2590943002/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_items_display_view_controller.mm:197: case
ItemTypePaymentItemTotal: {
I see that this is being done elsewhere in the code base but I was surprised to
see these braces here. What's the point of this? Is it just so that there can be
two declarations of a variable named "detailCell"?

[Moe, 2016-12-20 15:49:08]

Description was changed from

==========
Removes two unnecessary cells + adds missing unit test for an existing cell

BUG=602666
==========

to

==========
Removes two unnecessary cells + adds missing unit test for an existing cell.

BUG=602666
==========

[Moe, 2016-12-20 16:37:46]

On 2016/12/20 15:44:23, Justin Donnelly wrote:
> lgtm with a nit (please add a period to the end of the CL title and
description)
> and a question.
> 
>
https://codereview.chromium.org/2590943002/diff/1/ios/chrome/browser/payments...
> File ios/chrome/browser/payments/payment_items_display_view_controller.mm
> (right):
> 
>
https://codereview.chromium.org/2590943002/diff/1/ios/chrome/browser/payments...
> ios/chrome/browser/payments/payment_items_display_view_controller.mm:197: case
> ItemTypePaymentItemTotal: {
> I see that this is being done elsewhere in the code base but I was surprised
to
> see these braces here. What's the point of this? Is it just so that there can
be
> two declarations of a variable named "detailCell"?

I came across it for the first time myself too. I initially skipped it and
realized the compiler doesn't allow initializing a variable in a case block,
unless surrounded by curly brackets.

[Justin Donnelly, 2016-12-20 16:46:38]

https://codereview.chromium.org/2590943002/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_items_display_view_controller.mm
(right):

https://codereview.chromium.org/2590943002/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_items_display_view_controller.mm:197: case
ItemTypePaymentItemTotal: {
On 2016/12/20 15:44:23, Justin Donnelly wrote:
> I see that this is being done elsewhere in the code base but I was surprised
to
> see these braces here. What's the point of this? Is it just so that there can
be
> two declarations of a variable named "detailCell"?

Ah, I see. Thanks for the explanation.

[commit-bot: I haz the power, 2016-12-20 18:02:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 18:02:47]

Dry run: This issue passed the CQ dry run.

[Moe, 2016-12-20 18:10:17]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-12-20 18:10:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 18:16:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482257417473670, "parent_rev":
"a65c4408ed237b0a0518d87b826a6afb83deca8e", "commit_rev":
"2f5c51bca379fa4802516979ab88a2fbad747a94"}

[commit-bot: I haz the power, 2016-12-20 18:16:32]

Description was changed from

==========
Removes two unnecessary cells + adds missing unit test for an existing cell.

BUG=602666
==========

to

==========
Removes two unnecessary cells + adds missing unit test for an existing cell.

BUG=602666

Review-Url: https://codereview.chromium.org/2590943002
==========

[commit-bot: I haz the power, 2016-12-20 18:16:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-20 18:18:01]

Description was changed from

==========
Removes two unnecessary cells + adds missing unit test for an existing cell.

BUG=602666

Review-Url: https://codereview.chromium.org/2590943002
==========

to

==========
Removes two unnecessary cells + adds missing unit test for an existing cell.

BUG=602666

Committed: https://crrev.com/398d9f24b61c285c532d91d98d649fe6d563373d
Cr-Commit-Position: refs/heads/master@{#439847}
==========

[commit-bot: I haz the power, 2016-12-20 18:18:03]

Patchset 1 (id:??) landed as
https://crrev.com/398d9f24b61c285c532d91d98d649fe6d563373d
Cr-Commit-Position: refs/heads/master@{#439847}