Import wpt@009111410a1099e85d4027a679985975757ceb4d

Import wpt@009111410a1099e85d4027a679985975757ceb4d

Using update-w3c-deps in Chromium d0059913d4bbda3f638ae3a4212b22f4a78dbfde.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7835

TBR=qyearsley@chromium.org
NOEXPORT=true

Committed: https://crrev.com/29cd6645ccc33ac0ac87069ffa33b2cd8c634da0
Cr-Commit-Position: refs/heads/master@{#439825}

[blink-w3c-test-autoroller, 2016-12-20 15:18:39]

Modify TestExpectations or download new baselines for tests.

[blink-w3c-test-autoroller, 2016-12-20 15:18:41]

The CQ bit was checked by blink-w3c-test-autoroller@chromium.org

[commit-bot: I haz the power, 2016-12-20 15:19:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 16:54:17]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1482247121301800,
"parent_rev": "8abb2035f3d12ebd076255e44cdd0ccc2112051c", "commit_rev":
"e5fdfc8840b1061018f3fa7f577bf06d010cfa62"}

[commit-bot: I haz the power, 2016-12-20 16:54:42]

Description was changed from

==========
Import wpt@009111410a1099e85d4027a679985975757ceb4d

Using update-w3c-deps in Chromium d0059913d4bbda3f638ae3a4212b22f4a78dbfde.

Build:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...

TBR=qyearsley@chromium.org
NOEXPORT=true
==========

to

==========
Import wpt@009111410a1099e85d4027a679985975757ceb4d

Using update-w3c-deps in Chromium d0059913d4bbda3f638ae3a4212b22f4a78dbfde.

Build:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2590903002
==========

[commit-bot: I haz the power, 2016-12-20 16:54:43]

Committed patchset #2 (id:10001)

[qyearsley, 2016-12-20 16:57:58]

lgtm

[commit-bot: I haz the power, 2016-12-20 16:58:23]

Description was changed from

==========
Import wpt@009111410a1099e85d4027a679985975757ceb4d

Using update-w3c-deps in Chromium d0059913d4bbda3f638ae3a4212b22f4a78dbfde.

Build:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2590903002
==========

to

==========
Import wpt@009111410a1099e85d4027a679985975757ceb4d

Using update-w3c-deps in Chromium d0059913d4bbda3f638ae3a4212b22f4a78dbfde.

Build:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller...

TBR=qyearsley@chromium.org
NOEXPORT=true

Committed: https://crrev.com/29cd6645ccc33ac0ac87069ffa33b2cd8c634da0
Cr-Commit-Position: refs/heads/master@{#439825}
==========

[commit-bot: I haz the power, 2016-12-20 16:58:25]

Patchset 2 (id:??) landed as
https://crrev.com/29cd6645ccc33ac0ac87069ffa33b2cd8c634da0
Cr-Commit-Position: refs/heads/master@{#439825}

[tkent, 2016-12-20 23:26:49]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2016-12-20 23:26:50]

https://codereview.chromium.org/2590903002/diff/10001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2590903002/diff/10001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1791: crbug.com/626703 [ Trusty
Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
imported/wpt/html/dom/reflection-embedded.html [ Failure ]
It seems these tests are not failing. Why did the autoroller add Failure
entries?

[qyearsley, 2016-12-21 00:47:32]

https://codereview.chromium.org/2590903002/diff/10001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2590903002/diff/10001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1791: crbug.com/626703 [ Trusty
Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
imported/wpt/html/dom/reflection-embedded.html [ Failure ]
On 2016/12/20 at 23:26:50, tkent wrote:
> It seems these tests are not failing. Why did the autoroller add Failure
entries?

They appear to have failed in the first patch, e.g.:
https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/...

On the flakiness server it looks like the tests are currently failing, e.g.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

Does that seem right?

One other problem to note here though is that normally in most circumstances the
autoroller is supposed to add -expected.txt files if possible rather than
TestExpectations lines, and here TestExpectations lines were added. I think this
is because the previous expectation is "Slow" rather than "Pass". Just filed a
bug for this: http://crbug.com/676196

Action item here:
These lines should be removed and these tests should be rebaselined.

[tkent, 2016-12-21 00:51:36]

https://codereview.chromium.org/2590903002/diff/10001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2590903002/diff/10001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:1791: crbug.com/626703 [ Trusty
Mac10.11 Mac10.10 Retina Win7 Win10 Mac10.9 ]
imported/wpt/html/dom/reflection-embedded.html [ Failure ]
On 2016/12/21 at 00:47:32, qyearsley wrote:
> On 2016/12/20 at 23:26:50, tkent wrote:
> > It seems these tests are not failing. Why did the autoroller add Failure
entries?
> 
> They appear to have failed in the first patch, e.g.:
https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/...
> 
> On the flakiness server it looks like the tests are currently failing, e.g.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...
> 
> Does that seem right?

Ah, you're right.  I looked flakiness dashboard with a stale data.

> One other problem to note here though is that normally in most circumstances
the autoroller is supposed to add -expected.txt files if possible rather than
TestExpectations lines, and here TestExpectations lines were added. I think this
is because the previous expectation is "Slow" rather than "Pass". Just filed a
bug for this: http://crbug.com/676196
> 
> Action item here:
> These lines should be removed and these tests should be rebaselined.

yeah, they should be rebaselined.