Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2590893002: exo: Fix logic in |IsPhysicalKeyboardEnabled()|. (Closed)

Created:
4 years ago by yhanada
Modified:
4 years ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Fix logic in |IsPhysicalKeyboardEnabled()|. BUG=670247 TEST=Manual test by checking Configuration.hardKeyboardHidden when entering maximize mode. Committed: https://crrev.com/4a01cd06caf10ad886c51a17fe64aa255b7f4083 Cr-Commit-Position: refs/heads/master@{#439802}

Patch Set 1 #

Patch Set 2 : fix commit message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/exo/keyboard.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
yhanada
Hi reveman@, PTAL.
4 years ago (2016-12-20 14:08:05 UTC) #3
reveman
lgtm
4 years ago (2016-12-20 14:13:08 UTC) #4
yhanada
Thank you for the quick review!
4 years ago (2016-12-20 14:14:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590893002/20001
4 years ago (2016-12-20 14:14:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 14:45:29 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 14:48:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a01cd06caf10ad886c51a17fe64aa255b7f4083
Cr-Commit-Position: refs/heads/master@{#439802}

Powered by Google App Engine
This is Rietveld 408576698