Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2590883003: Fix leak in VRServiceImpl (Closed)

Created:
4 years ago by bshe
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix leak in VRServiceImpl This makes the implicit Strong Binding between the service and clients explicit, and fixes the service leaking when the binding is closed. No functional changes here. BUG=651245 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2571323002 Cr-Commit-Position: refs/heads/master@{#439333} (cherry picked from commit 7980a0e0ca7f5a6abda7e57ab28fbf8f845bfbf8) Committed: https://chromium.googlesource.com/chromium/src/+/225bb8d94ed0a406519a9935c6577a2855aafed1

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -31 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/vr_display_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M device/vr/vr_service_impl.h View 3 chunks +3 lines, -10 lines 0 comments Download
M device/vr/vr_service_impl.cc View 2 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
bshe
Committed patchset #2 (id:20001) manually as 225bb8d94ed0a406519a9935c6577a2855aafed1 (presubmit successful).
4 years ago (2016-12-21 18:53:42 UTC) #2
mthiesse
3 years, 11 months ago (2017-01-04 21:20:24 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2615723002/ by mthiesse@chromium.org.

The reason for reverting is: Causes crash on Chrome Beta 56.0.2924.51 .

Powered by Google App Engine
This is Rietveld 408576698