device/vr/vr_display_impl.cc - Issue 2590883003: Fix leak in VRServiceImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/vr_display_impl.cc

Issue 2590883003: Fix leak in VRServiceImpl (Closed)

Patch Set: fix compile Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/vr_display_impl.cc

diff --git a/device/vr/vr_display_impl.cc b/device/vr/vr_display_impl.cc

index 9c4b2c4960e98e5c7be7c2ed8c5515d33eb0f612..8fc00570607253d735a2b56a92d0c8150b7ef5bd 100644

--- a/device/vr/vr_display_impl.cc

+++ b/device/vr/vr_display_impl.cc

@@ -25,7 +25,9 @@ VRDisplayImpl::VRDisplayImpl(device::VRDevice* device, VRServiceImpl* service)

}

-VRDisplayImpl::~VRDisplayImpl() {}

+VRDisplayImpl::~VRDisplayImpl() {

+ device_->RemoveService(service_);

void VRDisplayImpl::GetPose(const GetPoseCallback& callback) {

if (!device_->IsAccessAllowed(service_)) {

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | device/vr/vr_service_impl.h » ('j') | no next file with comments »