Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2590863002: Removing obsolete code. (Closed)

Created:
4 years ago by noyau (Ping after 24h)
Modified:
4 years ago
Reviewers:
lpromero
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing obsolete code. BUG=None Committed: https://crrev.com/919a7a28ea1332621af567364e62377280ae4440 Cr-Commit-Position: refs/heads/master@{#439782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M ios/chrome/browser/ui/fullscreen_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/fullscreen_controller.mm View 2 chunks +0 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/fullscreen_controller_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
noyau (Ping after 24h)
This is leftover code from pre ios7, when the omnibox was autohiding.
4 years ago (2016-12-20 12:52:30 UTC) #2
lpromero
lgtm
4 years ago (2016-12-20 13:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590863002/1
4 years ago (2016-12-20 13:05:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 13:17:51 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 13:21:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/919a7a28ea1332621af567364e62377280ae4440
Cr-Commit-Position: refs/heads/master@{#439782}

Powered by Google App Engine
This is Rietveld 408576698