Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2590853002: Revert of Convert NaCl renderer-loader messages to mojo. (Closed)

Created:
4 years ago by markusheintz_
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert NaCl renderer-loader messages to mojo. (patchset #4 id:140001 of https://codereview.chromium.org/2525483002/ ) Reason for revert: CL does not compile on build bots e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/106780/steps/compile/logs/stdio Original issue's description: > Convert NaCl renderer-loader messages to mojo. > > BUG=577685 > > Committed: https://crrev.com/eb52daa79263d35ea1c62b717427bf68467be04f > Cr-Commit-Position: refs/heads/master@{#439770} TBR=mseaborn@chromium.org,bradnelson@chromium.org,jam@chromium.org,dcheng@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577685 Committed: https://crrev.com/1b02fcf4dc26130b0631c97ca996219b16e58519 Cr-Commit-Position: refs/heads/master@{#439771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -158 lines) Patch
M components/nacl/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/common/BUILD.gn View 5 chunks +2 lines, -15 lines 0 comments Download
M components/nacl/common/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/nacl/common/nacl.mojom View 1 chunk +0 lines, -26 lines 0 comments Download
D components/nacl/common/nacl.typemap View 1 chunk +0 lines, -15 lines 0 comments Download
A components/nacl/common/nacl_renderer_messages.h View 1 chunk +23 lines, -0 lines 0 comments Download
A components/nacl/common/nacl_renderer_messages.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M components/nacl/common/nacl_types_param_traits.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/nacl/loader/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M components/nacl/loader/nacl_trusted_listener.h View 1 chunk +17 lines, -9 lines 0 comments Download
M components/nacl/loader/nacl_trusted_listener.cc View 1 chunk +31 lines, -24 lines 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_listener.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M components/nacl/renderer/plugin/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M components/nacl/renderer/trusted_plugin_channel.h View 1 chunk +25 lines, -16 lines 0 comments Download
M components/nacl/renderer/trusted_plugin_channel.cc View 3 chunks +25 lines, -17 lines 0 comments Download
M components/typemaps.gni View 1 chunk +0 lines, -1 line 0 comments Download
M content/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
markusheintz_
Created Revert of Convert NaCl renderer-loader messages to mojo.
4 years ago (2016-12-20 12:07:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590853002/1
4 years ago (2016-12-20 12:07:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 12:09:14 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-20 12:10:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b02fcf4dc26130b0631c97ca996219b16e58519
Cr-Commit-Position: refs/heads/master@{#439771}

Powered by Google App Engine
This is Rietveld 408576698