[wasm] Only SNPrintF the function index if a name was not supplied.

[wasm] Only SNPrintF the function index if a name was not supplied.

R=clemensh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2590833002
Cr-Commit-Position: refs/heads/master@{#41863}
Committed: https://chromium.googlesource.com/v8/v8/+/058f1887157e7dc4dd707e3bbd3920bbcd668b09

[titzer, 2016-12-20 10:51:14]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 10:51:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 11:21:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 11:21:08]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-12-20 11:21:46]

Minor optimization, PTAL

[Clemens Hammacher, 2016-12-20 11:25:54]

https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc
File src/wasm/wasm-objects.cc (right):

https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc#ne...
src/wasm/wasm-objects.cc:317: ScopedVector<char> buffer(16);
We should make this an EmbeddedVector<char, 16>, such that it's completely
stack-allocated.
There are probably many more opportunities for this change.

[titzer, 2016-12-20 14:07:50]

On 2016/12/20 11:25:54, Clemens Hammacher wrote:
> https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc
> File src/wasm/wasm-objects.cc (right):
> 
>
https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc#ne...
> src/wasm/wasm-objects.cc:317: ScopedVector<char> buffer(16);
> We should make this an EmbeddedVector<char, 16>, such that it's completely
> stack-allocated.
> There are probably many more opportunities for this change.

Done.

[titzer, 2016-12-20 14:07:55]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-12-20 14:08:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 14:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 14:08:03]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Clemens Hammacher, 2016-12-20 14:10:01]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-12-20 14:10:01]

lgtm

[commit-bot: I haz the power, 2016-12-20 14:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 14:36:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482243001256680,
"parent_rev": "081ac37048676f7a55230b01603bf43cc5b55002", "commit_rev":
"058f1887157e7dc4dd707e3bbd3920bbcd668b09"}

[commit-bot: I haz the power, 2016-12-20 14:36:09]

Description was changed from

==========
[wasm] Only SNPrintF the function index if a name was not supplied.

R=clemensh@chromium.org
BUG=
==========

to

==========
[wasm] Only SNPrintF the function index if a name was not supplied.

R=clemensh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2590833002
Cr-Commit-Position: refs/heads/master@{#41863}
Committed:
https://chromium.googlesource.com/v8/v8/+/058f1887157e7dc4dd707e3bbd3920bbcd6...
==========

[commit-bot: I haz the power, 2016-12-20 14:36:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/058f1887157e7dc4dd707e3bbd3920bbcd6...