Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years ago by titzer Modified:
4 years ago Reviewers:
Clemens Hammacher CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Only SNPrintF the function index if a name was not supplied.
R=clemensh@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2590833002
Cr-Commit-Position: refs/heads/master@{#41863}
Committed: https://chromium.googlesource.com/v8/v8/+/058f1887157e7dc4dd707e3bbd3920bbcd668b09
Patch Set 1 #
Total comments: 1
Patch Set 2 : Use embedded vector. #
Created: 4 years ago
Messages
Total messages: 17 (9 generated)
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Minor optimization, PTAL
https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc File src/wasm/wasm-objects.cc (right): https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc#ne... src/wasm/wasm-objects.cc:317: ScopedVector<char> buffer(16); We should make this an EmbeddedVector<char, 16>, such that it's completely stack-allocated. There are probably many more opportunities for this change.
On 2016/12/20 11:25:54, Clemens Hammacher wrote: > https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc > File src/wasm/wasm-objects.cc (right): > > https://codereview.chromium.org/2590833002/diff/1/src/wasm/wasm-objects.cc#ne... > src/wasm/wasm-objects.cc:317: ScopedVector<char> buffer(16); > We should make this an EmbeddedVector<char, 16>, such that it's completely > stack-allocated. > There are probably many more opportunities for this change. Done.
The CQ bit was checked by titzer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by clemensh@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482243001256680,
"parent_rev": "081ac37048676f7a55230b01603bf43cc5b55002", "commit_rev":
"058f1887157e7dc4dd707e3bbd3920bbcd668b09"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Only SNPrintF the function index if a name was not supplied. R=clemensh@chromium.org BUG= ========== to ========== [wasm] Only SNPrintF the function index if a name was not supplied. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2590833002 Cr-Commit-Position: refs/heads/master@{#41863} Committed: https://chromium.googlesource.com/v8/v8/+/058f1887157e7dc4dd707e3bbd3920bbcd6... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/058f1887157e7dc4dd707e3bbd3920bbcd6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
