Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2590823005: Account Picker: fix window resize. (Closed)

Created:
3 years, 12 months ago by Alexander Alekseev
Modified:
3 years, 12 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Account Picker: fix window resize. When AccountPicker screeen is resized, its error bubble has to be repositioned. This is done 'reusing existing content' of error bubble, which led to exception. BUG=664094 Committed: https://crrev.com/ffc683508cd14f45a6fe8463224795a5c48c3c18 Cr-Commit-Position: refs/heads/master@{#440256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/login/account_picker/screen_account_picker.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Alexander Alekseev
Please review.
3 years, 12 months ago (2016-12-21 00:35:38 UTC) #2
xiyuan
lgtm
3 years, 12 months ago (2016-12-21 16:10:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590823005/1
3 years, 12 months ago (2016-12-21 22:59:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-21 23:06:20 UTC) #12
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 23:11:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffc683508cd14f45a6fe8463224795a5c48c3c18
Cr-Commit-Position: refs/heads/master@{#440256}

Powered by Google App Engine
This is Rietveld 408576698