Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2590823004:
Avoid float-cast-overflow in content::VideoCapturerSource::GetCurrentSupportedFormats (Closed)
|
Created:
4 years ago by emircan Modified:
3 years, 12 months ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid float-cast-overflow in content::VideoCapturerSource::GetCurrentSupportedFormats
This CL addresses the fuzz issue below by limiting the max fps given to
canvas capture by Chrome defined media::limits::kMaxFramesPerSecond. Note
that Chrome expects every video source to report GetCurrentSupportedFormats()
within the expected fps range. This limit isn't related to the blink side.
BUG=675309
Committed: https://crrev.com/5528e145e2e91990d2ee795549f0341bac6394a7
Cr-Commit-Position: refs/heads/master@{#440241}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== fuzz BUG= ========== to ========== Avoid float-cast-overflow in content::VideoCapturerSource::GetCurrentSupportedFormats This CL addresses the fuzz issue below by limiting the max fps given to canvas capture by Chrome defined media::limits::kMaxFramesPerSecond. Note that Chrome expects every video source to report GetCurrentSupportedFormats() within the expected fps range. This limit isn't related to the blink side. BUG=675309 ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
PTAL.
lgtm % comment/question Consider also checking for not frame_rate < 0.0 ? https://codereview.chromium.org/2590823004/diff/1/content/renderer/media/canv... File content/renderer/media/canvas_capture_handler.cc (right): https://codereview.chromium.org/2590823004/diff/1/content/renderer/media/canv... content/renderer/media/canvas_capture_handler.cc:44: : frame_rate_(static_cast<float>( Why not keep |frame_rate_| as double and avoid this extra static_cast<float> ?
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
framerate<0 is checked on blink level and specified by the spec. I added it here as DCHECK to make the expectation clear. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/mediac... https://codereview.chromium.org/2590823004/diff/1/content/renderer/media/canv... File content/renderer/media/canvas_capture_handler.cc (right): https://codereview.chromium.org/2590823004/diff/1/content/renderer/media/canv... content/renderer/media/canvas_capture_handler.cc:44: : frame_rate_(static_cast<float>( On 2016/12/20 22:57:14, mcasas wrote: > Why not keep |frame_rate_| as double and avoid > this extra static_cast<float> ? media::VideoCaptureFormat() in l.59-61 expect the input as a float. If I don't cast it here, it will be done implicitly twice.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by emircan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2590823004/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482358565219540,
"parent_rev": "d81bae3e37c5afc253d1f67f26f1a657a6089fff", "commit_rev":
"c083d7dac4a996434ab1c685535f34747e2d76fc"}
Message was sent while issue was closed.
Description was changed from ========== Avoid float-cast-overflow in content::VideoCapturerSource::GetCurrentSupportedFormats This CL addresses the fuzz issue below by limiting the max fps given to canvas capture by Chrome defined media::limits::kMaxFramesPerSecond. Note that Chrome expects every video source to report GetCurrentSupportedFormats() within the expected fps range. This limit isn't related to the blink side. BUG=675309 ========== to ========== Avoid float-cast-overflow in content::VideoCapturerSource::GetCurrentSupportedFormats This CL addresses the fuzz issue below by limiting the max fps given to canvas capture by Chrome defined media::limits::kMaxFramesPerSecond. Note that Chrome expects every video source to report GetCurrentSupportedFormats() within the expected fps range. This limit isn't related to the blink side. BUG=675309 Review-Url: https://codereview.chromium.org/2590823004 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Avoid float-cast-overflow in content::VideoCapturerSource::GetCurrentSupportedFormats This CL addresses the fuzz issue below by limiting the max fps given to canvas capture by Chrome defined media::limits::kMaxFramesPerSecond. Note that Chrome expects every video source to report GetCurrentSupportedFormats() within the expected fps range. This limit isn't related to the blink side. BUG=675309 Review-Url: https://codereview.chromium.org/2590823004 ========== to ========== Avoid float-cast-overflow in content::VideoCapturerSource::GetCurrentSupportedFormats This CL addresses the fuzz issue below by limiting the max fps given to canvas capture by Chrome defined media::limits::kMaxFramesPerSecond. Note that Chrome expects every video source to report GetCurrentSupportedFormats() within the expected fps range. This limit isn't related to the blink side. BUG=675309 Committed: https://crrev.com/5528e145e2e91990d2ee795549f0341bac6394a7 Cr-Commit-Position: refs/heads/master@{#440241} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5528e145e2e91990d2ee795549f0341bac6394a7 Cr-Commit-Position: refs/heads/master@{#440241} |
