Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2590803002: Pass URL to nativeProviders. (Closed)

Created:
4 years ago by Olivier
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass URL to nativeProviders. Pass the URL instead of the VirtualURL to the native providers and the webUI. BUG=671964 Committed: https://crrev.com/7cba97f95ce2d1569a68bd7b20ef7e06b15b8924 Cr-Commit-Position: refs/heads/master@{#439842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Olivier
Second part of the CL.
4 years ago (2016-12-20 08:54:35 UTC) #2
Eugene But (OOO till 7-30)
Thanks! lgtm
4 years ago (2016-12-20 17:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590803002/1
4 years ago (2016-12-20 17:40:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 18:04:42 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 18:08:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cba97f95ce2d1569a68bd7b20ef7e06b15b8924
Cr-Commit-Position: refs/heads/master@{#439842}

Powered by Google App Engine
This is Rietveld 408576698