Don't update global ruleset when active style is dirty.

Don't update global ruleset when active style is dirty.

CSSGlobalRuleSet should always be collected as part of the active style
update. RuleSets may have been cleared from StyleSheetContents as a
result of media query changes for instance.

For the given issue, we tried to limit to a global ruleset when lazy-
loading fullscreen UA style, but as part of going fullscreen we had
already cleared rule sets for stylesheets with media queries due to the
media feature change.

BUG=675439
Committed: https://crrev.com/0c3e8777424678b81c5306e832391050f65cb170
Cr-Commit-Position: refs/heads/master@{#439781}

[rune, 2016-12-20 10:31:15]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 10:31:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-12-20 10:33:54]

The CQ bit was unchecked by rune@opera.com

[rune, 2016-12-20 10:35:28]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 10:35:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-12-20 10:42:04]

rune@opera.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2016-12-20 10:46:33]

https://codereview.chromium.org/2590793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fullscreen/full-screen-ruleset-crash.html
(right):

https://codereview.chromium.org/2590793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fullscreen/full-screen-ruleset-crash.html:7: <div
id="fullscreen" onclick="this.requestFullscreen()">
Don't need "this.", I think.

https://codereview.chromium.org/2590793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fullscreen/full-screen-ruleset-crash.html:12:
eventSender.mouseMoveTo(fullscreen.offsetLeft + 1, fullscreen.offsetTop + 1);
Should check if eventSender exists.

[rune, 2016-12-20 10:55:41]

https://codereview.chromium.org/2590793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fullscreen/full-screen-ruleset-crash.html
(right):

https://codereview.chromium.org/2590793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fullscreen/full-screen-ruleset-crash.html:7: <div
id="fullscreen" onclick="this.requestFullscreen()">
On 2016/12/20 10:46:33, mstensho wrote:
> Don't need "this.", I think.

Done.

https://codereview.chromium.org/2590793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fullscreen/full-screen-ruleset-crash.html:12:
eventSender.mouseMoveTo(fullscreen.offsetLeft + 1, fullscreen.offsetTop + 1);
On 2016/12/20 10:46:33, mstensho wrote:
> Should check if eventSender exists.

Done.

[mstensho (USE GERRIT), 2016-12-20 11:41:30]

lgtm

[rune, 2016-12-20 11:41:42]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-12-20 11:41:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 13:16:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482234102742860,
"parent_rev": "38f822f5e65f1604b79cc6379a9f678592a63b53", "commit_rev":
"1bd55e34318b0927082c1686ae991b2b000cf368"}

[commit-bot: I haz the power, 2016-12-20 13:16:39]

Description was changed from

==========
Don't update global ruleset when active style is dirty.

CSSGlobalRuleSet should always be collected as part of the active style
update. RuleSets may have been cleared from StyleSheetContents as a
result of media query changes for instance.

For the given issue, we tried to limit to a global ruleset when lazy-
loading fullscreen UA style, but as part of going fullscreen we had
already cleared rule sets for stylesheets with media queries due to the
media feature change.

BUG=675439
==========

to

==========
Don't update global ruleset when active style is dirty.

CSSGlobalRuleSet should always be collected as part of the active style
update. RuleSets may have been cleared from StyleSheetContents as a
result of media query changes for instance.

For the given issue, we tried to limit to a global ruleset when lazy-
loading fullscreen UA style, but as part of going fullscreen we had
already cleared rule sets for stylesheets with media queries due to the
media feature change.

BUG=675439

Review-Url: https://codereview.chromium.org/2590793003
==========

[commit-bot: I haz the power, 2016-12-20 13:16:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-20 13:19:00]

Description was changed from

==========
Don't update global ruleset when active style is dirty.

CSSGlobalRuleSet should always be collected as part of the active style
update. RuleSets may have been cleared from StyleSheetContents as a
result of media query changes for instance.

For the given issue, we tried to limit to a global ruleset when lazy-
loading fullscreen UA style, but as part of going fullscreen we had
already cleared rule sets for stylesheets with media queries due to the
media feature change.

BUG=675439

Review-Url: https://codereview.chromium.org/2590793003
==========

to

==========
Don't update global ruleset when active style is dirty.

CSSGlobalRuleSet should always be collected as part of the active style
update. RuleSets may have been cleared from StyleSheetContents as a
result of media query changes for instance.

For the given issue, we tried to limit to a global ruleset when lazy-
loading fullscreen UA style, but as part of going fullscreen we had
already cleared rule sets for stylesheets with media queries due to the
media feature change.

BUG=675439

Committed: https://crrev.com/0c3e8777424678b81c5306e832391050f65cb170
Cr-Commit-Position: refs/heads/master@{#439781}
==========

[commit-bot: I haz the power, 2016-12-20 13:19:01]

Patchset 4 (id:??) landed as
https://crrev.com/0c3e8777424678b81c5306e832391050f65cb170
Cr-Commit-Position: refs/heads/master@{#439781}