Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2590713002: [CrOS Tether] Add a static TruncateDeviceIdForLogs() function. (Closed)

Created:
4 years ago by Kyle Horimoto
Modified:
4 years ago
Reviewers:
Ryan Hansberry
CC:
chromium-reviews, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, jlklein+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org, tengs+watch-tether_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Add a static TruncateDeviceIdForLogs() function. BUG=672263 Committed: https://crrev.com/281d37539a0bc4614cc2e1efadd9e773115fbc90 Cr-Commit-Position: refs/heads/master@{#439730}

Patch Set 1 #

Patch Set 2 : Fix style and variable name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -16 lines) Patch
M components/cryptauth/remote_device.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/cryptauth/remote_device.cc View 1 1 chunk +22 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Kyle Horimoto
4 years ago (2016-12-20 01:21:41 UTC) #2
Ryan Hansberry
lgtm
4 years ago (2016-12-20 05:36:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590713002/20001
4 years ago (2016-12-20 05:36:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 06:41:38 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 06:44:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/281d37539a0bc4614cc2e1efadd9e773115fbc90
Cr-Commit-Position: refs/heads/master@{#439730}

Powered by Google App Engine
This is Rietveld 408576698