Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2590673002: Fix a find_bar audible alert regression due to r404307. (Closed)

Created:
4 years ago by lazyboy
Modified:
4 years ago
Reviewers:
msw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a find_bar audible alert regression due to r404307. In refactor CL r404307, I mistakenly changed last_search.find(current_search) != 0 to StartsWith(last_search, current_search) instead of !StartsWith(last_search, current_search) This CL fixes the issue. BUG=674713 Test=Open any webpage, Ctrl+F to start search, start typing some word, audible alert should be heard as soon as the typed characters aren't found on the page. Committed: https://crrev.com/6cce238ff09415dfdb4f6786cfa314a48ae6e8ce Cr-Commit-Position: refs/heads/master@{#439644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/find_bar/find_bar_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
lazyboy
4 years ago (2016-12-19 22:23:16 UTC) #5
msw
lgtm
4 years ago (2016-12-19 22:30:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590673002/1
4 years ago (2016-12-20 00:50:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 00:57:08 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 00:58:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6cce238ff09415dfdb4f6786cfa314a48ae6e8ce
Cr-Commit-Position: refs/heads/master@{#439644}

Powered by Google App Engine
This is Rietveld 408576698