Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2590663002: Remove duplicate string constants for Web Bluetooth chooser on Android (Closed)

Created:
4 years ago by juncai
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate string constants for Web Bluetooth chooser on Android For the Web Bluetooth chooser string constants on Android, IDS_BLUETOOTH_SEARCHING and IDS_BLUETOOTH_NOT_SEEING_IT are the same. IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_NONE_FOUND and IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_SOME_FOUND are the same. This CL removes the duplicate strings. BUG=675723 Committed: https://crrev.com/50d25e524393a0e3b568e42f62a1bf3cab32a0dd Cr-Commit-Position: refs/heads/master@{#440789}

Patch Set 1 : remove duplicate string constants for Web Bluetooth chooser on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java View 1 chunk +9 lines, -17 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
juncai
Please take a look.
4 years ago (2016-12-19 21:34:29 UTC) #5
Ted C
lgtm
3 years, 12 months ago (2016-12-27 20:28:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590663002/1
3 years, 12 months ago (2016-12-27 20:45:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-27 21:16:10 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50d25e524393a0e3b568e42f62a1bf3cab32a0dd
Cr-Commit-Position: refs/heads/master@{#440789}

Powered by Google App Engine
This is Rietveld 408576698