Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2590563002: [wasm] Cleanup unneeded casts to WasmInstanceObject (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Cleanup unneeded casts to WasmInstanceObject Plus another minor refactoring. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2590563002 Cr-Commit-Position: refs/heads/master@{#41853} Committed: https://chromium.googlesource.com/v8/v8/+/fb43021511676963898c3d166d2d921632deb5d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -31 lines) Patch
M src/frames.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-wasm.cc View 2 chunks +16 lines, -26 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Clemens Hammacher
4 years ago (2016-12-19 19:06:30 UTC) #5
titzer
lgtm
4 years ago (2016-12-19 20:38:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590563002/1
4 years ago (2016-12-20 11:47:45 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 11:49:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fb43021511676963898c3d166d2d921632d...

Powered by Google App Engine
This is Rietveld 408576698