[CrOS Tether] Create ble_constants.h/cc, which include common constants to be shared among multiple…

[CrOS Tether] Create ble_constants.h/cc, which include common constants to be shared among multiple BLE-related classes.

BUG=672263
Committed: https://crrev.com/6c4fcc1e46dc5ac58e4368441592f770a6251e21
Cr-Commit-Position: refs/heads/master@{#439738}

[Kyle Horimoto, 2016-12-20 01:52:19]

khorimoto@chromium.org changed reviewers:
+ hansberry@chromium.org

[Ryan Hansberry, 2016-12-20 05:21:09]

lgtm

https://codereview.chromium.org/2590553003/diff/1/chromeos/components/tether/...
File chromeos/components/tether/ble_constants.h (right):

https://codereview.chromium.org/2590553003/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_constants.h:5: #ifndef
CHROMEOS_COMPONENTS_BLE_CONSTANTS_H_
nit: should be CHROMEOS_COMPONENTS_TETHER_BLE_CONSTANTS_H_

https://codereview.chromium.org/2590553003/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_constants.h:21: extern const int
kMaxConcurrentAdvertisements;
Will this need to be used anywhere else in the future? I don't mind it being
here, I'm just curious.

[Kyle Horimoto, 2016-12-20 05:31:32]

https://codereview.chromium.org/2590553003/diff/1/chromeos/components/tether/...
File chromeos/components/tether/ble_constants.h (right):

https://codereview.chromium.org/2590553003/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_constants.h:5: #ifndef
CHROMEOS_COMPONENTS_BLE_CONSTANTS_H_
On 2016/12/20 05:21:09, Ryan Hansberry wrote:
> nit: should be CHROMEOS_COMPONENTS_TETHER_BLE_CONSTANTS_H_

Done.

https://codereview.chromium.org/2590553003/diff/1/chromeos/components/tether/...
chromeos/components/tether/ble_constants.h:21: extern const int
kMaxConcurrentAdvertisements;
On 2016/12/20 05:21:09, Ryan Hansberry wrote:
> Will this need to be used anywhere else in the future? I don't mind it being
> here, I'm just curious.

Yes, it will be used by the scanner and advertiser.

[Kyle Horimoto, 2016-12-20 05:31:35]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2016-12-20 05:31:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
hansberry@chromium.org
Link to the patchset: https://codereview.chromium.org/2590553003/#ps20001
(title: "hansberry@ comments.")

[commit-bot: I haz the power, 2016-12-20 05:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 07:50:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482211895985310,
"parent_rev": "c9f44f8b0e1122610c4f42298f1af6903bd1536f", "commit_rev":
"7269ddefcac0661e7a9b399f7c0e70d9cb8281c0"}

[commit-bot: I haz the power, 2016-12-20 07:50:27]

Description was changed from

==========
[CrOS Tether] Create ble_constants.h/cc, which include common constants to be
shared among multiple BLE-related classes.

BUG=672263
==========

to

==========
[CrOS Tether] Create ble_constants.h/cc, which include common constants to be
shared among multiple BLE-related classes.

BUG=672263

Review-Url: https://codereview.chromium.org/2590553003
==========

[commit-bot: I haz the power, 2016-12-20 07:50:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 07:52:15]

Description was changed from

==========
[CrOS Tether] Create ble_constants.h/cc, which include common constants to be
shared among multiple BLE-related classes.

BUG=672263

Review-Url: https://codereview.chromium.org/2590553003
==========

to

==========
[CrOS Tether] Create ble_constants.h/cc, which include common constants to be
shared among multiple BLE-related classes.

BUG=672263

Committed: https://crrev.com/6c4fcc1e46dc5ac58e4368441592f770a6251e21
Cr-Commit-Position: refs/heads/master@{#439738}
==========

[commit-bot: I haz the power, 2016-12-20 07:52:15]

Patchset 2 (id:??) landed as
https://crrev.com/6c4fcc1e46dc5ac58e4368441592f770a6251e21
Cr-Commit-Position: refs/heads/master@{#439738}