Update TaskTraits in browser_main_loop.cc.

Update TaskTraits in browser_main_loop.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660
Committed: https://crrev.com/acfcc22d49973a71c3b5c9848f7564504a9b858c
Cr-Commit-Position: refs/heads/master@{#440144}

[fdoray, 2016-12-21 15:53:36]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:53:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-21 16:13:25]

fdoray@chromium.org changed reviewers:
+ avi@chromium.org

[fdoray, 2016-12-21 16:13:25]

PTAL

[gab, 2016-12-21 16:16:57]

lgtm w/ comment

https://codereview.chromium.org/2590413003/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2590413003/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:1016: // don't need to.
This TODO was meant to flag WithWait() being overkill for most tasks.

(i.e. remove "blocking and" as blocking is expected on to stay on these threads)

[Avi (use Gerrit), 2016-12-21 16:24:18]

lgtm

[fdoray, 2016-12-21 16:26:19]

https://codereview.chromium.org/2590413003/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2590413003/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:1016: // don't need to.
On 2016/12/21 16:16:57, gab wrote:
> This TODO was meant to flag WithWait() being overkill for most tasks.
> 
> (i.e. remove "blocking and" as blocking is expected on to stay on these
threads)

Done.

[fdoray, 2016-12-21 16:26:22]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-21 16:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2590413003/#ps20001
(title: "fix todo")

[commit-bot: I haz the power, 2016-12-21 16:26:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:52:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482337582156350,
"parent_rev": "eb164650fef291a43b19b9542b6d94c44bbbac86", "commit_rev":
"79346b7e99f41539aaadea1825cee5f68c3d8223"}

[commit-bot: I haz the power, 2016-12-21 17:52:54]

Description was changed from

==========
Update TaskTraits in browser_main_loop.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660
==========

to

==========
Update TaskTraits in browser_main_loop.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2590413003
==========

[commit-bot: I haz the power, 2016-12-21 17:52:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 17:57:30]

Description was changed from

==========
Update TaskTraits in browser_main_loop.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Review-Url: https://codereview.chromium.org/2590413003
==========

to

==========
Update TaskTraits in browser_main_loop.cc.

The .WithFileIO() and .WithWait() traits were deprecated in favor of
.MayBlock() and .WithSyncPrimitives(). See rationale in
https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73...

.MayBlock()
Tasks with this trait may block. This includes but is not limited to tasks
that wait on synchronous file I/O operations: read or write a file from
disk, interact with a pipe or a socket, rename or delete a file, enumerate
files in a directory, etc. This trait does not allow tasks to wait on
synchronization primitives (thread or process handles, waitable events,
condition variables).

.WithSyncPrimitives()
Tasks with this trait are allowed to block on synchronization primitives
(wait on a waitable event/condition variable, join a process/thread).
This trait implies MayBlock(), i.e. you do not need to specify MayBlock()
for a task that blocks exclusively on synchronization primitives.

R=gab@chromium.org
BUG=675660

Committed: https://crrev.com/acfcc22d49973a71c3b5c9848f7564504a9b858c
Cr-Commit-Position: refs/heads/master@{#440144}
==========

[commit-bot: I haz the power, 2016-12-21 17:57:31]

Patchset 2 (id:??) landed as
https://crrev.com/acfcc22d49973a71c3b5c9848f7564504a9b858c
Cr-Commit-Position: refs/heads/master@{#440144}