[builtins] Add ReturnReceiver builtin

[builtins] Add ReturnReceiver builtin

This removes RegExpPrototypeSpeciesGetter and IteratorPrototypeIterator and
uses ReturnReceiver builtin instead.

This patch also ports the PromiseSpecies to TF by reusing this
builtin.

BUG=v8:5343
Review-Url: https://codereview.chromium.org/2590373002
Cr-Commit-Position: refs/heads/master@{#41879}
Committed: https://chromium.googlesource.com/v8/v8/+/90291792e68f812df8f225f8528cb7755bbfa76b

[gsathya, 2016-12-20 19:51:38]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 19:51:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-12-20 19:52:15]

Description was changed from

==========
[promises] Move promise[@@species] to TF

This also adds the `[Symbol.species]` to heap-symbols.

BUG=v8:5343
==========

to

==========
[promises] Move promise[@@species] to TF

This also adds the "[Symbol.species]" to heap-symbols.

BUG=v8:5343
==========

[gsathya, 2016-12-20 19:52:15]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[gsathya, 2016-12-20 19:57:21]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 19:57:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 20:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 20:36:24]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-12-20 23:03:12]

https://codereview.chromium.org/2590373002/diff/20001/src/builtins/builtins-p...
File src/builtins/builtins-promise.cc (right):

https://codereview.chromium.org/2590373002/diff/20001/src/builtins/builtins-p...
src/builtins/builtins-promise.cc:994: TF_BUILTIN(PromiseSpeciesGetter,
PromiseBuiltinsAssembler) {
Seems like we should only need one of these builtins (not one for Promise, one
for RegExp, etc). Maybe put it in builtins-internal.cc?

[gsathya, 2016-12-20 23:16:32]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:16:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-12-20 23:48:13]

On 2016/12/20 23:03:12, adamk wrote:
>
https://codereview.chromium.org/2590373002/diff/20001/src/builtins/builtins-p...
> File src/builtins/builtins-promise.cc (right):
> 
>
https://codereview.chromium.org/2590373002/diff/20001/src/builtins/builtins-p...
> src/builtins/builtins-promise.cc:994: TF_BUILTIN(PromiseSpeciesGetter,
> PromiseBuiltinsAssembler) {
> Seems like we should only need one of these builtins (not one for Promise, one
> for RegExp, etc). Maybe put it in builtins-internal.cc?

Done

[commit-bot: I haz the power, 2016-12-20 23:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 23:48:18]

Dry run: This issue passed the CQ dry run.

[caitp, 2016-12-20 23:58:05]

caitp@igalia.com changed reviewers:
+ caitp@igalia.com

[caitp, 2016-12-20 23:58:06]

https://codereview.chromium.org/2590373002/diff/20001/src/builtins/builtins-p...
File src/builtins/builtins-promise.cc (right):

https://codereview.chromium.org/2590373002/diff/20001/src/builtins/builtins-p...
src/builtins/builtins-promise.cc:994: TF_BUILTIN(PromiseSpeciesGetter,
PromiseBuiltinsAssembler) {
On 2016/12/20 23:03:12, adamk wrote:
> Seems like we should only need one of these builtins (not one for Promise, one
> for RegExp, etc). Maybe put it in builtins-internal.cc?

%IteratorPrototype%[@@iterator] can reuse this code, too.

[gsathya, 2016-12-21 00:12:15]

Description was changed from

==========
[promises] Move promise[@@species] to TF

This also adds the "[Symbol.species]" to heap-symbols.

BUG=v8:5343
==========

to

==========
[builtins] Add ReturnReceiver builtin

This removes RegExpPrototypeSpeciesGetter and IteratorNextIterator and
uses ReturnReceiver builtin instead.

This patch also ports the PromiseSpecies to TF by reusing this
builtin.

BUG=v8:5343
==========

[gsathya, 2016-12-21 00:12:53]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:13:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-12-21 00:13:24]

Description was changed from

==========
[builtins] Add ReturnReceiver builtin

This removes RegExpPrototypeSpeciesGetter and IteratorNextIterator and
uses ReturnReceiver builtin instead.

This patch also ports the PromiseSpecies to TF by reusing this
builtin.

BUG=v8:5343
==========

to

==========
[builtins] Add ReturnReceiver builtin

This removes RegExpPrototypeSpeciesGetter and IteratorPrototypeIterator and
uses ReturnReceiver builtin instead.

This patch also ports the PromiseSpecies to TF by reusing this
builtin.

BUG=v8:5343
==========

[adamk, 2016-12-21 00:15:07]

lgtm

[commit-bot: I haz the power, 2016-12-21 00:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:44:45]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-12-21 00:49:04]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:49:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:51:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482281344885690,
"parent_rev": "b0c05f4ab351a0a595c551489e08fec83be75d11", "commit_rev":
"90291792e68f812df8f225f8528cb7755bbfa76b"}

[commit-bot: I haz the power, 2016-12-21 00:51:18]

Description was changed from

==========
[builtins] Add ReturnReceiver builtin

This removes RegExpPrototypeSpeciesGetter and IteratorPrototypeIterator and
uses ReturnReceiver builtin instead.

This patch also ports the PromiseSpecies to TF by reusing this
builtin.

BUG=v8:5343
==========

to

==========
[builtins] Add ReturnReceiver builtin

This removes RegExpPrototypeSpeciesGetter and IteratorPrototypeIterator and
uses ReturnReceiver builtin instead.

This patch also ports the PromiseSpecies to TF by reusing this
builtin.

BUG=v8:5343

Review-Url: https://codereview.chromium.org/2590373002
Cr-Commit-Position: refs/heads/master@{#41879}
Committed:
https://chromium.googlesource.com/v8/v8/+/90291792e68f812df8f225f8528cb7755bb...
==========

[commit-bot: I haz the power, 2016-12-21 00:51:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/90291792e68f812df8f225f8528cb7755bb...