Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2590293004:
RTCPeerConnection.getStats: Whitelist updated after spec changed. (Closed)
|
Created:
4 years ago by hbos_chromium Modified:
3 years, 11 months ago Reviewers:
hta - Chromium CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRTCPeerConnection.getStats: Whitelist updated after spec changed.
This is the whitelist used in the Chromium integration test.
New members:
- RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum
- RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded
- RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded
- RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid
- RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote
- RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted
Renamed members, removed old names (https://codereview.webrtc.org/2576383002/):
- RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
- RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime
NOTRY=True
BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723
Committed: https://crrev.com/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a
Cr-Commit-Position: refs/heads/master@{#441073}
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
The CQ bit was checked by hbos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Description was changed from ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. BUG=chromium:627816 ========== to ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 ==========
hbos@chromium.org changed reviewers: + hta@chromium.org
Please take a look, hta.
Description was changed from ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 ========== to ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. This is the whitelist used in the Chromium integration test. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Description was changed from ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. This is the whitelist used in the Chromium integration test. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 ========== to ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. This is the whitelist used in the Chromium integration test. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... NOTRY=True BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 ==========
The CQ bit was checked by hbos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483375208151940,
"parent_rev": "6773afc9beaf38400c80d5f19c6dbbfdb503e5b7", "commit_rev":
"c11d658b76ef0f4e7e18b1d634c84fa60cb77790"}
Message was sent while issue was closed.
Description was changed from ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. This is the whitelist used in the Chromium integration test. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... NOTRY=True BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 ========== to ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. This is the whitelist used in the Chromium integration test. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... NOTRY=True BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 Review-Url: https://codereview.chromium.org/2590293004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. This is the whitelist used in the Chromium integration test. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... NOTRY=True BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 Review-Url: https://codereview.chromium.org/2590293004 ========== to ========== RTCPeerConnection.getStats: Whitelist updated after spec changed. This is the whitelist used in the Chromium integration test. New members: - RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum - RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded - RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded - RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid - RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote - RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted Renamed members, removed old names (https://codereview.webrtc.org/2576383002/): - RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtr... - RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentround... NOTRY=True BUG=chromium:627816, chromium:657854, chromium:657855, chromium:657856, chromium:632723 Committed: https://crrev.com/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a Cr-Commit-Position: refs/heads/master@{#441073} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a Cr-Commit-Position: refs/heads/master@{#441073} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
