Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)
Patch Set: addressed comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.h
diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h
index 32f80267eb3d92094559c551ead1a7011d8bc636..7f8206701874e487d74b686d5fc41806fadc47e5 100644
--- a/content/browser/devtools/protocol/page_handler.h
+++ b/content/browser/devtools/protocol/page_handler.h
@@ -12,6 +12,7 @@
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
#include "cc/output/compositor_frame_metadata.h"
+#include "content/browser/devtools/protocol/devtools_domain_handler.h"
#include "content/browser/devtools/protocol/page.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -30,14 +31,15 @@ namespace protocol {
class ColorPicker;
-class PageHandler : public Page::Backend,
+class PageHandler : public DevToolsDomainHandler,
+ public Page::Backend,
public NotificationObserver {
public:
PageHandler();
~PageHandler() override;
- void Wire(UberDispatcher*);
- void SetRenderFrameHost(RenderFrameHostImpl* host);
+ void Wire(UberDispatcher* dispatcher) override;
+ void SetRenderFrameHost(RenderFrameHostImpl* host) override;
void OnSwapCompositorFrame(cc::CompositorFrameMetadata frame_metadata);
void OnSynchronousSwapCompositorFrame(
cc::CompositorFrameMetadata frame_metadata);

Powered by Google App Engine
This is Rietveld 408576698