content/browser/devtools/protocol/page_handler.cc - Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 2590293003: [DevTools] Rework DevToolsSession interaction with domain handlers. (Closed)

Patch Set: addressed comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/page_handler.cc

diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc

index 99e6ad202a1efb4789b6456a895c77c7e91c8cf4..fdd1967310d827b4911c26fc5d70e27a85884626 100644

--- a/content/browser/devtools/protocol/page_handler.cc

+++ b/content/browser/devtools/protocol/page_handler.cc

@@ -90,7 +90,8 @@ std::string EncodeScreencastFrame(const SkBitmap& bitmap,

} // namespace

PageHandler::PageHandler()

- : enabled_(false),

+ : DevToolsDomainHandler(Page::Metainfo::domainName),

+ enabled_(false),

screencast_enabled_(false),

screencast_quality_(kDefaultScreenshotQuality),

screencast_max_width_(-1),