Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2590273005: Add unit test for color managed ImageBitamp(HTMLCanvasElement) constructor (Closed)

Created:
4 years ago by zakerinasab
Modified:
4 years ago
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, haraken, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit test for color managed ImageBitamp(HTMLCanvasElement) constructor This CL is a follow up for CL 2522693002, part of color management implementation for ImageBitmap as described in proposal: (github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md) BUG=665919 Committed: https://crrev.com/f9801783df3fe00bf8e78e26bc4ed898f9df2281 Cr-Commit-Position: refs/heads/master@{#440207}

Patch Set 1 #

Patch Set 2 : Minor corrections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 2 chunks +141 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
zakerinasab1
New CL for ImageBitmap color correction. PTAL.
4 years ago (2016-12-21 15:18:32 UTC) #4
Justin Novosad
lgtm
4 years ago (2016-12-21 17:49:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590273005/20001
4 years ago (2016-12-21 18:08:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 20:57:52 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-21 20:59:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9801783df3fe00bf8e78e26bc4ed898f9df2281
Cr-Commit-Position: refs/heads/master@{#440207}

Powered by Google App Engine
This is Rietveld 408576698