Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2590273002: Move WebMouseEvent into its own header file. (Closed)

Created:
4 years ago by dtapuska
Modified:
3 years, 11 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org, scheib+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, sebsg+autofillwatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, rouslan+autofill_chromium.org, eae+blinkwatch, csharrison+watch_chromium.org, piman+watch_chromium.org, jochen+watch_chromium.org, dtapuska+blinkwatch_chromium.org, mlamouri+watch-test-runner_chromium.org, mathp+autofillwatch_chromium.org, loading-reviews+metrics_chromium.org, jdonnelly+autofillwatch_chromium.org, blink-reviews-events_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, einbinder+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebMouseEvent into its own header file. No changes other than modifying includes and appropriately forward declaring the class. BUG=625684 TBR=girard@chromium.org, clamy@chromium.org, jochen@chromium.org Review-Url: https://codereview.chromium.org/2590273002 Cr-Commit-Position: refs/heads/master@{#441940} Committed: https://chromium.googlesource.com/chromium/src/+/a794bd081b2465e336f2ad92f9e8c45c140ea144

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -52 lines) Patch
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_input_manager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/page_click_tracker.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/render_view_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/mouse_lock_dispatcher_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/WebMouseEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 1 1 chunk +0 lines, -47 lines 0 comments Download
A third_party/WebKit/public/platform/WebMouseEvent.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebMouseWheelEvent.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (18 generated)
dtapuska
3 years, 11 months ago (2017-01-05 22:17:21 UTC) #12
Rick Byers
LGTM This is a trivial transform of blink headers, I'd TBR a content reviewer personally ...
3 years, 11 months ago (2017-01-06 14:04:32 UTC) #15
dtapuska
girard@chromium.org: Please review changes in vr_shell/* clamy@chromium.org: Please review changes in content/* jochen@chromium.org: Please review ...
3 years, 11 months ago (2017-01-06 14:15:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590273002/40001
3 years, 11 months ago (2017-01-06 14:16:11 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 15:23:33 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a794bd081b2465e336f2ad92f9e8...

Powered by Google App Engine
This is Rietveld 408576698