Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2590243003: [wasm] Set JS API names and function lengths appropriately. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Set JS API names and function lengths appropriately. R=clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2590243003 Cr-Commit-Position: refs/heads/master@{#41885} Committed: https://chromium.googlesource.com/v8/v8/+/01c464a5af0147917e3e88457474d8c24c971ae0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -46 lines) Patch
M src/wasm/wasm-js.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 9 chunks +50 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
4 years ago (2016-12-20 16:56:51 UTC) #1
Clemens Hammacher
lgtm
4 years ago (2016-12-20 17:10:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590243003/1
4 years ago (2016-12-21 09:02:00 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 09:03:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/01c464a5af0147917e3e88457474d8c24c9...

Powered by Google App Engine
This is Rietveld 408576698