Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2590223002:
[ios] Fixes the recent tabs button on the NTP. (Closed)
|
Created:
4 years ago by rohitrao (ping after 24h) Modified:
4 years ago CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ios] Fixes the recent tabs button on the NTP.
I added parentheses to the frame calculation expression to work around
clang-format issues, but I added them in the wrong place and made the math
wrong. This CL removes the parentheses and restores the original expression.
BUG=675595
Committed: https://crrev.com/0c55868e7f2c7a3d94c561e843a6cf97c4a4d0c4
Cr-Commit-Position: refs/heads/master@{#439813}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fixes the recent tabs button on the NTP. I added parentheses to the frame calculation expression to work around clang-format issues, but I added them in the wrong place and made the math wrong. This CL removes the parentheses and restores the original expression. BUG=675595 ========== to ========== [ios] Fixes the recent tabs button on the NTP. I added parentheses to the frame calculation expression to work around clang-format issues, but I added them in the wrong place and made the math wrong. This CL removes the parentheses and restores the original expression. BUG=675595 ==========
rohitrao@chromium.org changed reviewers: + justincohen@chromium.org, lpromero@chromium.org
sdefresne@chromium.org changed reviewers: + sdefresne@chromium.org
lgtm
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rohitrao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482249340732040, "parent_rev":
"2f53f11c7477308705233e316cec093e72add0a3", "commit_rev":
"8f8017c2c0b3567d3a0f782cd3488fb9e63851d1"}
Message was sent while issue was closed.
Description was changed from ========== [ios] Fixes the recent tabs button on the NTP. I added parentheses to the frame calculation expression to work around clang-format issues, but I added them in the wrong place and made the math wrong. This CL removes the parentheses and restores the original expression. BUG=675595 ========== to ========== [ios] Fixes the recent tabs button on the NTP. I added parentheses to the frame calculation expression to work around clang-format issues, but I added them in the wrong place and made the math wrong. This CL removes the parentheses and restores the original expression. BUG=675595 Review-Url: https://codereview.chromium.org/2590223002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [ios] Fixes the recent tabs button on the NTP. I added parentheses to the frame calculation expression to work around clang-format issues, but I added them in the wrong place and made the math wrong. This CL removes the parentheses and restores the original expression. BUG=675595 Review-Url: https://codereview.chromium.org/2590223002 ========== to ========== [ios] Fixes the recent tabs button on the NTP. I added parentheses to the frame calculation expression to work around clang-format issues, but I added them in the wrong place and made the math wrong. This CL removes the parentheses and restores the original expression. BUG=675595 Committed: https://crrev.com/0c55868e7f2c7a3d94c561e843a6cf97c4a4d0c4 Cr-Commit-Position: refs/heads/master@{#439813} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0c55868e7f2c7a3d94c561e843a6cf97c4a4d0c4 Cr-Commit-Position: refs/heads/master@{#439813} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
