Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2590183002: Don't force an interstitial when showing a login prompt for a standalone app (Closed)

Created:
4 years ago by jochen (gone - plz use gerrit)
Modified:
4 years ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, chromium-reviews, vabr+watchlistlogin_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't force an interstitial when showing a login prompt for a standalone app BUG=664838 R=mlamouri@chromium.org Committed: https://crrev.com/73a71ba1b6637d9b3bc485bd4cefb639b9c42da4 Cr-Commit-Position: refs/heads/master@{#439790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/login/login_handler.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jochen (gone - plz use gerrit)
4 years ago (2016-12-20 12:40:02 UTC) #1
mlamouri (slow - plz ping)
lgtm Thanks for fixing this! :)
4 years ago (2016-12-20 13:15:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590183002/1
4 years ago (2016-12-20 13:22:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 13:37:41 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 13:41:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73a71ba1b6637d9b3bc485bd4cefb639b9c42da4
Cr-Commit-Position: refs/heads/master@{#439790}

Powered by Google App Engine
This is Rietveld 408576698