Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2590173002: Convert NaCl renderer-loader messages to mojo. (Closed)

Created:
4 years ago by blundell
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert NaCl renderer-loader messages to mojo. Author: Sam McNally <sammc@chromium.org>; Reland of https://codereview.chromium.org/2525483002/, with trivial fixes applied to fix bustage that occurred due to that CL racing with https://codereview.chromium.org/2589663003/. BUG=577685 TBR=sammc, dcheng Committed: https://crrev.com/30c19915c5cc51ebcbb05700cedb0d84e7f60c2a Cr-Commit-Position: refs/heads/master@{#439783}

Patch Set 1 #

Patch Set 2 : GetProxy() -> MakeRequest() #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -181 lines) Patch
M components/nacl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/common/BUILD.gn View 5 chunks +15 lines, -2 lines 0 comments Download
M components/nacl/common/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A components/nacl/common/nacl.mojom View 1 chunk +26 lines, -0 lines 0 comments Download
A components/nacl/common/nacl.typemap View 1 chunk +15 lines, -0 lines 0 comments Download
D components/nacl/common/nacl_renderer_messages.h View 1 chunk +0 lines, -23 lines 0 comments Download
D components/nacl/common/nacl_renderer_messages.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M components/nacl/common/nacl_types_param_traits.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/nacl/loader/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/nacl/loader/nacl_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 4 chunks +9 lines, -10 lines 0 comments Download
M components/nacl/loader/nacl_trusted_listener.h View 1 chunk +9 lines, -17 lines 0 comments Download
M components/nacl/loader/nacl_trusted_listener.cc View 1 1 chunk +24 lines, -31 lines 1 comment Download
M components/nacl/loader/nonsfi/nonsfi_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_listener.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M components/nacl/renderer/plugin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M components/nacl/renderer/trusted_plugin_channel.h View 1 chunk +15 lines, -24 lines 0 comments Download
M components/nacl/renderer/trusted_plugin_channel.cc View 2 chunks +17 lines, -25 lines 0 comments Download
M components/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M content/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
blundell
This is just https://codereview.chromium.org/2525483002/ with s/GetProxy()/MakeRequest() to adjust to my CL, which landed in the ...
4 years ago (2016-12-20 12:21:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590173002/20001
4 years ago (2016-12-20 12:22:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 13:21:37 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/30c19915c5cc51ebcbb05700cedb0d84e7f60c2a Cr-Commit-Position: refs/heads/master@{#439783}
4 years ago (2016-12-20 13:24:24 UTC) #11
dcheng
still lgtm
4 years ago (2016-12-20 17:33:35 UTC) #12
Sam McNally
LGTM. Thanks for relanding.
4 years ago (2016-12-20 23:15:52 UTC) #13
brucedawson
4 years ago (2016-12-21 01:12:29 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2590173002/diff/20001/components/nacl/loader/...
File components/nacl/loader/nacl_trusted_listener.cc (right):

https://codereview.chromium.org/2590173002/diff/20001/components/nacl/loader/...
components/nacl/loader/nacl_trusted_listener.cc:25: NaClExit(0);
VC++ hates having a call to exit() in a destructor, and the PGO builders are
hitting this. I think it's a silly warning so I'm suppressing it.

FYI.

Powered by Google App Engine
This is Rietveld 408576698