Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2590143002: [NTP::PhysicalWeb] Do not show "More" button. (Closed)

Created:
4 years ago by vitaliii
Modified:
4 years ago
Reviewers:
jkrcal
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::PhysicalWeb] Do not show "More" button. The PRD has been changed, so now we should not show the "More" button in the Physical Web section. BUG=674897 Committed: https://crrev.com/676a125a7100cbbebbab0f9e786b605b136401e8 Cr-Commit-Position: refs/heads/master@{#439761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
vitaliii
[XS CL - 1 line] Hi jkrcal@, PTAL.
4 years ago (2016-12-20 09:33:40 UTC) #2
jkrcal
lgtm
4 years ago (2016-12-20 09:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590143002/1
4 years ago (2016-12-20 10:05:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 10:17:32 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 10:19:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/676a125a7100cbbebbab0f9e786b605b136401e8
Cr-Commit-Position: refs/heads/master@{#439761}

Powered by Google App Engine
This is Rietveld 408576698