Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2590123004: Fix RTL mode for the account picker on Mac. (Closed)

Created:
4 years ago by vasilii
Modified:
4 years ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix RTL mode for the account picker on Mac. The avatar icon should be on the right side in the RTL mode. BUG=666340 Committed: https://crrev.com/2dc41cfe18693c87dfafcb351975be768919ae06 Cr-Commit-Position: refs/heads/master@{#440371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/passwords/credential_item_button.mm View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
vasilii
Hi Vaclav, please review the CL.
4 years ago (2016-12-21 19:17:35 UTC) #3
vabr (Chromium)
Hi Vasilii, The code LGTM. Given that the bug itself is a generic tracking bug, ...
4 years ago (2016-12-21 19:55:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590123004/1
4 years ago (2016-12-22 09:36:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 09:41:29 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-22 09:44:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dc41cfe18693c87dfafcb351975be768919ae06
Cr-Commit-Position: refs/heads/master@{#440371}

Powered by Google App Engine
This is Rietveld 408576698