Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2590053002:
Disable failing and flaky CTS tests (Closed)
|
Created:
4 years ago by the real yoland Modified:
4 years ago CC:
android-webview-reviews_chromium.org, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable failing and flaky CTS tests
Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow,
which has been flaky on L and N bot, and ServiceWorkerClientTest
testServiceWorkerClientInterceptCallback, which has been failing on N bot
BUG=659077, 675809
Committed: https://crrev.com/b89f0113f539b02c742c7eb1588767282dd0ddb6
Cr-Commit-Position: refs/heads/master@{#439840}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
yolandyan@chromium.org changed reviewers: + mikecase@chromium.org, sgurun@chromium.org
iirc, the testServiceWorkerClientInterceptCallback is just failing every single run on N. Might want to update commit message to "Disable failing and flaky CTS tests" and then maybe write out the test names you are disabling in the commit dec. lgtm though
Description was changed from ========== Disable flaky CTS BUG=659077, 675809 ========== to ========== Disable failing and flaky CTS tests BUG=659077, 675809 ==========
Description was changed from ========== Disable failing and flaky CTS tests BUG=659077, 675809 ========== to ========== Disable android.webkit.cts.WebViewClientTest#testShouldOverrideUrlLoadingOnCreateWindow, which has been flaky on L and N bot, and android.webkit.cts.ServiceWorkerClientTest#testServiceWorkerClientInterceptCallback, which has been failing on N bot BUG=659077, 675809 ==========
The CQ bit was checked by yolandyan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mikecase@chromium.org
I think you mistakenly made the commit msg suuuuper long.
Description was changed from ========== Disable android.webkit.cts.WebViewClientTest#testShouldOverrideUrlLoadingOnCreateWindow, which has been flaky on L and N bot, and android.webkit.cts.ServiceWorkerClientTest#testServiceWorkerClientInterceptCallback, which has been failing on N bot BUG=659077, 675809 ========== to ========== Disable failing and flaky CTS tests Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow, which has been flaky on L and N bot, and ServiceWorkerClientTest testServiceWorkerClientInterceptCallback, which has been failing on N bot BUG=659077, 675809 ==========
The CQ bit was checked by yolandyan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482256359397680, "parent_rev":
"c5607c8ff723dd47416af7e7a07f883c314ced5f", "commit_rev":
"b3dc67ae6d4840ca7ec2e674068f356615d2a793"}
Message was sent while issue was closed.
Description was changed from ========== Disable failing and flaky CTS tests Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow, which has been flaky on L and N bot, and ServiceWorkerClientTest testServiceWorkerClientInterceptCallback, which has been failing on N bot BUG=659077, 675809 ========== to ========== Disable failing and flaky CTS tests Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow, which has been flaky on L and N bot, and ServiceWorkerClientTest testServiceWorkerClientInterceptCallback, which has been failing on N bot BUG=659077, 675809 Review-Url: https://codereview.chromium.org/2590053002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable failing and flaky CTS tests Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow, which has been flaky on L and N bot, and ServiceWorkerClientTest testServiceWorkerClientInterceptCallback, which has been failing on N bot BUG=659077, 675809 Review-Url: https://codereview.chromium.org/2590053002 ========== to ========== Disable failing and flaky CTS tests Disable WebViewClientTest testShouldOverrideUrlLoadingOnCreateWindow, which has been flaky on L and N bot, and ServiceWorkerClientTest testServiceWorkerClientInterceptCallback, which has been failing on N bot BUG=659077, 675809 Committed: https://crrev.com/b89f0113f539b02c742c7eb1588767282dd0ddb6 Cr-Commit-Position: refs/heads/master@{#439840} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b89f0113f539b02c742c7eb1588767282dd0ddb6 Cr-Commit-Position: refs/heads/master@{#439840} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
