Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2590013002: Allow MetricsReportingScheduler's histograms to be overriden. (Closed)

Created:
4 years ago by Steven Holte
Modified:
3 years, 11 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow MetricsReportingScheduler's histograms to be overriden. This will allow different schedulers to write to different histograms. BUG= Committed: https://crrev.com/065d745fb4022710eda3fda095d5c7849599a28f Cr-Commit-Position: refs/heads/master@{#440812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M components/metrics/metrics_reporting_scheduler.h View 2 chunks +14 lines, -1 line 0 comments Download
M components/metrics/metrics_reporting_scheduler.cc View 2 chunks +13 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Steven Holte
Maybe this style would be better for PersistedLogs too.
4 years ago (2016-12-19 23:08:59 UTC) #2
rkaplow
lgtm
4 years ago (2016-12-19 23:30:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590013002/1
3 years, 11 months ago (2016-12-27 23:13:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 00:12:50 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/065d745fb4022710eda3fda095d5c7849599a28f
Cr-Commit-Position: refs/heads/master@{#440812}

Powered by Google App Engine
This is Rietveld 408576698