Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2130)

Issue 2589973003: Revert of Improve saturated_cast performance (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
Tom Sepez, Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve saturated_cast performance (patchset #4 id:160001 of https://codereview.chromium.org/2585043002/ ) Reason for revert: thakis@ thinks it hit this bug: https://llvm.org/bugs/show_bug.cgi?id=29122 Will re-land after it's resolved. Original issue's description: > Improve saturated_cast performance > > Plumb custom bounds through DstRangeRelationToSrcRange to remove > duplicate comparisons. Refactor RangeConstraint from an enum to a class > containing bools, which can be independently evaluated at compile-time. > > NOTRY=true > > Committed: https://crrev.com/8b34cfe3286eea1b7107cfa74eb19a5195e3dda9 > Cr-Commit-Position: refs/heads/master@{#439508} TBR=tsepez@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3e898ba2883687e17121e437d900280d811503d1 Cr-Commit-Position: refs/heads/master@{#439559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -129 lines) Patch
M base/numerics/safe_conversions.h View 1 chunk +23 lines, -23 lines 0 comments Download
M base/numerics/safe_conversions_impl.h View 4 chunks +58 lines, -95 lines 0 comments Download
M base/numerics/safe_numerics_unittest.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jschuh
Created Revert of Improve saturated_cast performance
4 years ago (2016-12-19 21:12:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589973003/1
4 years ago (2016-12-19 21:12:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 21:13:58 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-19 21:15:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e898ba2883687e17121e437d900280d811503d1
Cr-Commit-Position: refs/heads/master@{#439559}

Powered by Google App Engine
This is Rietveld 408576698