Issue 2589963002: Prevent drag-and-drop events from firing over cross-site, same-page frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2589963002: Prevent drag-and-drop events from firing over cross-site, same-page frames. (Closed)

Created:
4 years ago by paulmeyer

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Prevent drag-and-drop events from firing over cross-site, same-page frames. This is a follow-up to https://codereview.chromium.org/2568893002/, enabling the same behavior on Mac. Review-Url: https://codereview.chromium.org/2580843003 Cr-Commit-Position: refs/heads/master@{#438911} (cherry picked from commit 0678253f9e9c12a1cc704721ae6e013860bb909e) BUG=666858 Committed: https://chromium.googlesource.com/chromium/src/+/4ac976937b9c8c65e6eeb34678d7a7031fc0fdc3

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -3 lines)			Patch
M	content/browser/web_contents/web_contents_view_mac.mm	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/web_drag_dest_mac.h	View	3 chunks	+18 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_drag_dest_mac.mm	View	7 chunks	+33 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

paulmeyer

4 years ago (2016-12-19 20:45:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4ac976937b9c8c65e6eeb34678d7a7031fc0fdc3.