Prevent drag-and-drop events from firing over cross-site, same-page frames. (Mac)

Prevent drag-and-drop events from firing over cross-site, same-page
frames.

This is a follow-up to https://codereview.chromium.org/2568893002/,
enabling the same behavior on Mac.

Committed: https://crrev.com/0678253f9e9c12a1cc704721ae6e013860bb909e
Cr-Commit-Position: refs/heads/master@{#438911}

[paulmeyer, 2016-12-15 17:39:27]

Description was changed from

==========
WIP drag security Mac.
==========

to

==========
Prevent drag-and-drop events from firing over cross-site, same-page
frames.

This is a follow-up to https://codereview.chromium.org/2568893002/,
enabling the same behavior on Mac.
==========

[paulmeyer, 2016-12-15 17:40:53]

The CQ bit was checked by paulmeyer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 17:41:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[paulmeyer, 2016-12-15 18:04:07]

paulmeyer@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-12-15 19:40:08]

LGTM with grammar nits.

ObjC style is to name the parameters to the left of the :; I suggested some
names if you want them.

https://codereview.chromium.org/2580843003/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_drag_dest_mac.h (right):

https://codereview.chromium.org/2580843003/diff/20001/content/browser/web_con...
content/browser/web_contents/web_drag_dest_mac.h:49: // which the current drag
originated. These are set in setDragStartTrackers(),
"....These are set in -setDragStartTrackersForProcess:, and are used..."

https://codereview.chromium.org/2580843003/diff/20001/content/browser/web_con...
content/browser/web_contents/web_drag_dest_mac.h:92: -
(void)setDragStartTrackers:(int)processID;
setDragStartTrackersForProcess:(int)processID

[paulmeyer, 2016-12-15 20:02:33]

Patchset #3 (id:40001) has been deleted

[paulmeyer, 2016-12-15 20:02:35]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2016-12-15 20:02:36]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2580843003/#ps60001
(title: "Addressed grammar nits.")

[paulmeyer, 2016-12-15 20:02:51]

https://codereview.chromium.org/2580843003/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_drag_dest_mac.h (right):

https://codereview.chromium.org/2580843003/diff/20001/content/browser/web_con...
content/browser/web_contents/web_drag_dest_mac.h:49: // which the current drag
originated. These are set in setDragStartTrackers(),
On 2016/12/15 19:40:08, Avi wrote:
> "....These are set in -setDragStartTrackersForProcess:, and are used..."

Done.

https://codereview.chromium.org/2580843003/diff/20001/content/browser/web_con...
content/browser/web_contents/web_drag_dest_mac.h:92: -
(void)setDragStartTrackers:(int)processID;
On 2016/12/15 19:40:08, Avi wrote:
> setDragStartTrackersForProcess:(int)processID

Done.

[commit-bot: I haz the power, 2016-12-15 20:03:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 20:26:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481832155898850,
"parent_rev": "e98fdf43ced790e071573b8994188c8230b577f9", "commit_rev":
"3704613d7ee6737610bc9fc3167aec2936bdd9c2"}

[commit-bot: I haz the power, 2016-12-15 20:26:38]

Description was changed from

==========
Prevent drag-and-drop events from firing over cross-site, same-page
frames.

This is a follow-up to https://codereview.chromium.org/2568893002/,
enabling the same behavior on Mac.
==========

to

==========
Prevent drag-and-drop events from firing over cross-site, same-page
frames.

This is a follow-up to https://codereview.chromium.org/2568893002/,
enabling the same behavior on Mac.

Review-Url: https://codereview.chromium.org/2580843003
==========

[commit-bot: I haz the power, 2016-12-15 20:26:39]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-15 20:29:00]

Description was changed from

==========
Prevent drag-and-drop events from firing over cross-site, same-page
frames.

This is a follow-up to https://codereview.chromium.org/2568893002/,
enabling the same behavior on Mac.

Review-Url: https://codereview.chromium.org/2580843003
==========

to

==========
Prevent drag-and-drop events from firing over cross-site, same-page
frames.

This is a follow-up to https://codereview.chromium.org/2568893002/,
enabling the same behavior on Mac.

Committed: https://crrev.com/0678253f9e9c12a1cc704721ae6e013860bb909e
Cr-Commit-Position: refs/heads/master@{#438911}
==========

[commit-bot: I haz the power, 2016-12-15 20:29:00]

Patchset 3 (id:??) landed as
https://crrev.com/0678253f9e9c12a1cc704721ae6e013860bb909e
Cr-Commit-Position: refs/heads/master@{#438911}