Wrap the conditional in CHECK with UNLIKELY since it is.

Wrap the conditional in CHECK with UNLIKELY since it is.

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
BUG=672699
Committed: https://crrev.com/cb7c529ef85e7df2b109e549cc94d90f4a1e6e24
Cr-Commit-Position: refs/heads/master@{#439860}

[danakj, 2016-12-19 19:53:16]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 19:53:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-12-19 20:04:35]

LGTM, seems reasonable.

[Primiano Tucci (use gerrit), 2016-12-19 20:16:05]

On 2016/12/19 19:53:11, danakj_OOO_and_slow wrote:

Oh I think Scott forgot this is his CL. I'm quite sure he had this at some point
but maybe got lost in the revert-reland process.
think should really be a noop:
- on windows UNLIKELY -> noop (both in base and blink)
- on linux IMMEDIATE_CRASH() == __builtin_trap() and __builtin_trap is
implicitly noreturn. One would hope that that a compiler is smart enough to
figure out that a noreturn branch is unlikey  :)
But yup, won't hurt

[danakj, 2016-12-19 20:30:37]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-12-19 20:30:41]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-12-19 20:30:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-12-19 20:30:58]

On 2016/12/19 20:16:05, Primiano Tucci wrote:
> On 2016/12/19 19:53:11, danakj_OOO_and_slow wrote:
> 
> Oh I think Scott forgot this is his CL. I'm quite sure he had this at some
point
> but maybe got lost in the revert-reland process.
> think should really be a noop:
> - on windows UNLIKELY -> noop (both in base and blink)
> - on linux IMMEDIATE_CRASH() == __builtin_trap() and __builtin_trap is
> implicitly noreturn. One would hope that that a compiler is smart enough to
> figure out that a noreturn branch is unlikey  :)
> But yup, won't hurt

I guess that could explain why perf bots didn't notice anything.

[danakj, 2016-12-19 20:31:31]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-12-19 20:32:09]

Description was changed from

==========
Wrap the conditional in CHECK with UNLIKELY since it is.

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
==========

to

==========
Wrap the conditional in CHECK with UNLIKELY since it is.

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
BUG=672699
==========

[danakj, 2016-12-19 20:32:12]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-12-19 20:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:55:20]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-12-19 22:01:27]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-12-19 22:02:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 00:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:04:18]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-12-20 15:16:49]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-12-20 15:17:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 19:05:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482247009590540, "parent_rev":
"52b0d0c8795ed2503ac13dbdafd94b8aab8fb603", "commit_rev":
"607b25ce6bf7f8008b925e280c487362981f18df"}

[commit-bot: I haz the power, 2016-12-20 19:06:04]

Description was changed from

==========
Wrap the conditional in CHECK with UNLIKELY since it is.

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
BUG=672699
==========

to

==========
Wrap the conditional in CHECK with UNLIKELY since it is.

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
BUG=672699

Review-Url: https://codereview.chromium.org/2589943002
==========

[commit-bot: I haz the power, 2016-12-20 19:06:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-20 19:08:42]

Description was changed from

==========
Wrap the conditional in CHECK with UNLIKELY since it is.

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
BUG=672699

Review-Url: https://codereview.chromium.org/2589943002
==========

to

==========
Wrap the conditional in CHECK with UNLIKELY since it is.

This matches what was done in RELEASE_ASSERT in blink. No perf
bots noticed this being missing (it does nothing on windows which
is where perf bots noticed anything) but it won't hurt right.

R=dcheng@chromium.org
BUG=672699

Committed: https://crrev.com/cb7c529ef85e7df2b109e549cc94d90f4a1e6e24
Cr-Commit-Position: refs/heads/master@{#439860}
==========

[commit-bot: I haz the power, 2016-12-20 19:08:43]

Patchset 1 (id:??) landed as
https://crrev.com/cb7c529ef85e7df2b109e549cc94d90f4a1e6e24
Cr-Commit-Position: refs/heads/master@{#439860}