Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2589853002: [heap] Turn on black allocation. (Closed)

Created:
4 years ago by Hannes Payer (out of office)
Modified:
4 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Turn on black allocation. BUG= Review-Url: https://codereview.chromium.org/2589853002 Cr-Commit-Position: refs/heads/master@{#41815} Committed: https://chromium.googlesource.com/v8/v8/+/dc03ed581101aed961b7fba818602b1fe528d368

Patch Set 1 #

Patch Set 2 : [heap] Turn on black allocation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
ulan
lgtm
4 years ago (2016-12-19 16:39:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589853002/20001
4 years ago (2016-12-19 16:39:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/dc03ed581101aed961b7fba818602b1fe528d368
4 years ago (2016-12-19 17:10:03 UTC) #10
Hannes Payer (out of office)
4 years ago (2016-12-19 18:40:21 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2588833002/ by hpayer@chromium.org.

The reason for reverting is: Yeah, off again..

Powered by Google App Engine
This is Rietveld 408576698