Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2589823003: [crankshaft] Properly handle OOB string accesses. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Properly handle OOB string accesses. BUG=chromium:665793 Review-Url: https://codereview.chromium.org/2589823003 Cr-Commit-Position: refs/heads/master@{#41842} Committed: https://chromium.googlesource.com/v8/v8/+/576a46f5204b13cb09be82ee60232bd819d3e737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-665793.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-20 09:44:45 UTC) #11
Benedikt Meurer
lgtm
4 years ago (2016-12-20 09:57:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589823003/20001
4 years ago (2016-12-20 10:00:04 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-20 10:02:06 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/576a46f5204b13cb09be82ee60232bd819d...

Powered by Google App Engine
This is Rietveld 408576698