Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2589813002: base/allocator/partition_alloc: make unittests lowmem friendly (Closed)

Created:
4 years ago by Primiano Tucci (use gerrit)
Modified:
4 years ago
Reviewers:
haraken, palmer
CC:
chromium-reviews, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, danakj, mbjorge
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base/allocator/partition_alloc: make unittests lowmem friendly Partition Alloc, which has been recently moved to base/, has tests that rely on the ability to successfully make large (512 MB) allocations. Turns out this is not possible on small devices like ChromeCast, that seem to either have little overcommit margins or a heavily fragmented address space. This CL skips those tests on devices that have < 2 GiB of physical memory. For the same reason, it lowers down the chunk size of the RepeatedReturnNullDirect test. The rationale of the test is to check that repeated failures are handled consistently when performing directly mapped allocations. The chunk size is irrelevant as long as it is big enough to hit the directly-mmap codepaths (current threshold = 1 MB). BUG=675255 Committed: https://crrev.com/3ac3dbf4347193119fa3f31db087fd87db2e99dd Cr-Commit-Position: refs/heads/master@{#439484}

Patch Set 1 #

Patch Set 2 : fix asan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M base/allocator/partition_allocator/partition_alloc_unittest.cc View 1 5 chunks +25 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Primiano Tucci (use gerrit)
haraken@ can you take a look at this? looks like palmer is ooo for a ...
4 years ago (2016-12-19 14:06:23 UTC) #4
haraken
LGTM
4 years ago (2016-12-19 15:12:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589813002/20001
4 years ago (2016-12-19 15:59:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 16:03:25 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-19 16:06:25 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ac3dbf4347193119fa3f31db087fd87db2e99dd
Cr-Commit-Position: refs/heads/master@{#439484}

Powered by Google App Engine
This is Rietveld 408576698