Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2589653002: Remove LifecycleNotifier::removePending (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LifecycleNotifier::removePending It's unused BUG=610176 Committed: https://crrev.com/216a94bf46972065bc416c85ad0956b7b6eafb9c Cr-Commit-Position: refs/heads/master@{#439450}

Patch Set 1 #

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M third_party/WebKit/Source/platform/LifecycleNotifier.h View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
haraken
PTAL
4 years ago (2016-12-19 05:47:29 UTC) #2
sof
lgtm Its use being removed along with stop(), https://codereview.chromium.org/2366253002
4 years ago (2016-12-19 07:56:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589653002/20001
4 years ago (2016-12-19 08:02:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/201576)
4 years ago (2016-12-19 09:51:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589653002/20001
4 years ago (2016-12-19 09:55:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 10:38:20 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 10:41:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/216a94bf46972065bc416c85ad0956b7b6eafb9c
Cr-Commit-Position: refs/heads/master@{#439450}

Powered by Google App Engine
This is Rietveld 408576698