Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2589643002: mediaview: Register ARC documents provider file system. (Closed)

Created:
4 years ago by Shuhei Takahashi
Modified:
3 years, 11 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mediaview: Register ARC documents provider file system. ArcContentFileSystemService is renamed to ArcFileSystemService, and it will register two ARC file systems. Also constants in arc_content_file_system_url_util.h are renamed now that we have two ARC file systems. BUG=chromium:671511 TEST=unit_tests --gtest_filter='Arc*' TEST=trybot Review-Url: https://codereview.chromium.org/2589643002 Cr-Commit-Position: refs/heads/master@{#441905} Committed: https://chromium.googlesource.com/chromium/src/+/3022c4f86fd02985e11e524e951512c85c4f4268

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Rebased. #

Patch Set 4 : Addressed lhchavez's comments. #

Patch Set 5 : Rebased #

Messages

Total messages: 26 (19 generated)
Shuhei Takahashi
lhchavez, hashimoto: PTAL
4 years ago (2016-12-19 11:35:03 UTC) #8
Luis Héctor Chávez
lgtm with a nit. https://codereview.chromium.org/2589643002/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h File chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h (right): https://codereview.chromium.org/2589643002/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h#newcode20 chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h:20: public InstanceHolder<mojom::FileSystemInstance>::Observer { You don't ...
4 years ago (2016-12-19 22:37:27 UTC) #11
Shuhei Takahashi
hashimoto: PTAL https://codereview.chromium.org/2589643002/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h File chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h (right): https://codereview.chromium.org/2589643002/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h#newcode20 chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h:20: public InstanceHolder<mojom::FileSystemInstance>::Observer { On 2016/12/19 22:37:27, Luis ...
3 years, 11 months ago (2017-01-05 08:49:43 UTC) #12
hashimoto
lgtm
3 years, 11 months ago (2017-01-05 09:24:13 UTC) #15
commit-bot: I haz the power
This CL has an open dependency (Issue 2580713004 Patch 200001). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-06 05:39:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589643002/80001
3 years, 11 months ago (2017-01-06 08:02:21 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 09:04:51 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3022c4f86fd02985e11e524e9515...

Powered by Google App Engine
This is Rietveld 408576698