lgtm with a nit. https://codereview.chromium.org/2589643002/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h File chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h (right): https://codereview.chromium.org/2589643002/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h#newcode20 chrome/browser/chromeos/arc/fileapi/arc_file_system_service.h:20: public InstanceHolder<mojom::FileSystemInstance>::Observer { You don't ...
This CL has an open dependency (Issue 2580713004 Patch 200001). Please resolve the dependency and ...
3 years, 11 months ago
(2017-01-06 05:39:46 UTC)
#21
This CL has an open dependency (Issue 2580713004 Patch 200001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.
Shuhei Takahashi
The CQ bit was checked by nya@chromium.org
3 years, 11 months ago
(2017-01-06 08:02:09 UTC)
#22
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483689729005670, "parent_rev": "8e9a8aabbde296324fa081995177dd5aac5622e4", "commit_rev": "3022c4f86fd02985e11e524e951512c85c4f4268"}
3 years, 11 months ago
(2017-01-06 09:04:22 UTC)
#24
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483689729005670,
"parent_rev": "8e9a8aabbde296324fa081995177dd5aac5622e4", "commit_rev":
"3022c4f86fd02985e11e524e951512c85c4f4268"}
commit-bot: I haz the power
Description was changed from ========== mediaview: Register ARC documents provider file system. ArcContentFileSystemService is renamed ...
3 years, 11 months ago
(2017-01-06 09:04:49 UTC)
#25
Message was sent while issue was closed.
Description was changed from
==========
mediaview: Register ARC documents provider file system.
ArcContentFileSystemService is renamed to ArcFileSystemService, and it
will register two ARC file systems.
Also constants in arc_content_file_system_url_util.h are renamed
now that we have two ARC file systems.
BUG=chromium:671511
TEST=unit_tests --gtest_filter='Arc*'
TEST=trybot
==========
to
==========
mediaview: Register ARC documents provider file system.
ArcContentFileSystemService is renamed to ArcFileSystemService, and it
will register two ARC file systems.
Also constants in arc_content_file_system_url_util.h are renamed
now that we have two ARC file systems.
BUG=chromium:671511
TEST=unit_tests --gtest_filter='Arc*'
TEST=trybot
Review-Url: https://codereview.chromium.org/2589643002
Cr-Commit-Position: refs/heads/master@{#441905}
Committed:
https://chromium.googlesource.com/chromium/src/+/3022c4f86fd02985e11e524e9515...
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/3022c4f86fd02985e11e524e951512c85c4f4268
3 years, 11 months ago
(2017-01-06 09:04:51 UTC)
#26
Issue 2589643002: mediaview: Register ARC documents provider file system.
(Closed)
Created 4 years ago by Shuhei Takahashi
Modified 3 years, 11 months ago
Reviewers: Luis Héctor Chávez, hashimoto
Base URL:
Comments: 2