Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2589613002: Revert of Extend CopyTextureCHROMIUM to more ES 3.0 texture formats. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
CC:
chromium-reviews, piman+watch_chromium.org, Yang Gu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extend CopyTextureCHROMIUM to more ES 3.0 texture formats. (patchset #27 id:620001 of https://codereview.chromium.org/2479513002/ ) Reason for revert: Caused crashes in dozens of layout tests. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/21138 Original issue's description: > Extend CopyTextureCHROMIUM to more ES 3.0 texture formats. > > Add support for the following copying techniques: > > 1) Using CopyTexImage2D when the source is color-renderable. > > 2) Drawing a quad when the destination is color-renderable. > > 3) Drawing to an intermediate texture, and copying from that > intermediate texture to the destination, when neither is > color-renderable. > > Add support for nearly all of the new ES 3.0 texture formats. > > Follow-on work remains, including some scenarios described in the bug, > such as copying to faces of currently-incomplete cube maps. > > BUG=612542 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/bcf132827ebd0436fd3620bbda4cbcf3febdc161 > Cr-Commit-Position: refs/heads/master@{#439312} TBR=kbr@chromium.org,zmo@chromium.org,yunchao.he@intel.com,qiankun.miao@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=612542 Committed: https://crrev.com/f1c05a3a8f62bb12a94141b9501e6d246ab6e7ad Cr-Commit-Position: refs/heads/master@{#439411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -1174 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 2 chunks +32 lines, -32 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 6 chunks +3 lines, -31 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 13 chunks +189 lines, -520 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 17 chunks +64 lines, -171 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 5 chunks +3 lines, -412 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
tkent
Created Revert of Extend CopyTextureCHROMIUM to more ES 3.0 texture formats.
4 years ago (2016-12-19 03:55:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589613002/1
4 years ago (2016-12-19 03:56:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 04:59:21 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-19 05:01:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1c05a3a8f62bb12a94141b9501e6d246ab6e7ad
Cr-Commit-Position: refs/heads/master@{#439411}

Powered by Google App Engine
This is Rietveld 408576698