Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2589583003: Upstream Chrome on iOS source code [7/11]. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, tfarina, pkl (ping after 24h if needed), stkhapugin, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Chrome on iOS source code [7/11]. Upstream part of Chrome on iOS source code. Nothing is built yet, just new files added. The files will be added to the build as part of the last CL to avoid breaking downstream tree. BUG=653086 Committed: https://crrev.com/ceea172d0994ae358ff2c562efbedfd897faa182 Cr-Commit-Position: refs/heads/master@{#439469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16549 lines, -0 lines) Patch
A ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller.mm View 1 chunk +368 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm View 1 chunk +834 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_checker.h View 1 chunk +78 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm View 1 chunk +166 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_controller.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_controller.mm View 1 chunk +309 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_infobar_delegate.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_infobar_delegate.mm View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_view.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reader_mode/reader_mode_view.mm View 1 chunk +137 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/number_badge_view.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/number_badge_view.mm View 1 chunk +130 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/offline_page_native_content.h View 1 chunk +41 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/offline_page_native_content.mm View 1 chunk +82 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/offline_page_native_content_unittest.mm View 1 chunk +61 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm View 1 chunk +223 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_egtest.mm View 1 chunk +373 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_menu_notification_delegate.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.mm View 1 chunk +100 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.mm View 1 chunk +73 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_toolbar.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_toolbar.mm View 1 chunk +261 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_view_controller.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm View 1 chunk +998 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.mm View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_view_controller_unittest.mm View 1 chunk +180 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/sad_tab/sad_tab_view.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/sad_tab/sad_tab_view.mm View 1 chunk +401 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/README.md View 1 chunk +9 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm View 1 chunk +185 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/about_chrome_collection_view_controller_unittest.mm View 1 chunk +90 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/accounts_collection_egtest.mm View 1 chunk +314 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/accounts_collection_view_controller.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm View 1 chunk +677 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_collection_view_controller.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm View 1 chunk +629 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_collection_view_controller_unittest.mm View 1 chunk +141 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_credit_card_edit_collection_view_controller.mm View 1 chunk +273 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_edit_accessory_view.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_edit_accessory_view.mm View 1 chunk +198 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_edit_collection_view_controller.mm View 1 chunk +182 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller.mm View 1 chunk +239 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_profile_edit_collection_view_controller_unittest.mm View 1 chunk +132 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/autofill_settings_egtest.mm View 1 chunk +225 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller.mm View 1 chunk +220 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/bandwidth_management_collection_view_controller_unittest.mm View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/bar_button_activity_indicator.h View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/bar_button_activity_indicator.mm View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/block_popups_collection_view_controller.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm View 1 chunk +366 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/block_popups_collection_view_controller_unittest.mm View 1 chunk +173 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/block_popups_egtest.mm View 1 chunk +300 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/account_control_item.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/account_control_item.mm View 1 chunk +216 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/account_control_item_unittest.mm View 1 chunk +81 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/account_signin_item.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/account_signin_item.mm View 1 chunk +175 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/account_signin_item_unittest.mm View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/autofill_data_item.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/autofill_data_item.mm View 1 chunk +182 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/autofill_data_item_unittest.mm View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/autofill_edit_item.h View 1 chunk +45 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/autofill_edit_item.mm View 1 chunk +150 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/autofill_edit_item_unittest.mm View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/byo_textfield_item.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/byo_textfield_item.mm View 1 chunk +102 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/byo_textfield_item_unittest.mm View 1 chunk +30 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/card_multiline_item.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/card_multiline_item.mm View 1 chunk +93 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/card_multiline_item_unittest.mm View 1 chunk +40 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.h View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.mm View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/copied_to_chrome_item_unittest.mm View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/encryption_item.h View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/encryption_item.mm View 1 chunk +136 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/encryption_item_unittest.mm View 1 chunk +36 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_cell.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_cell.mm View 1 chunk +111 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_cell_unittest.mm View 1 chunk +53 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/native_app_item.h View 1 chunk +58 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/native_app_item.mm View 1 chunk +191 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/native_app_item_unittest.mm View 1 chunk +77 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/passphrase_error_item.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/passphrase_error_item.mm View 1 chunk +96 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/passphrase_error_item_unittest.mm View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/password_details_item.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/password_details_item.mm View 1 chunk +113 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/password_details_item_unittest.mm View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/sync_switch_item.h View 1 chunk +50 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/sync_switch_item.mm View 1 chunk +193 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/sync_switch_item_unittest.mm View 1 chunk +98 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/text_and_error_item.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/text_and_error_item.mm View 1 chunk +166 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/text_and_error_item_unittest.mm View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/version_item.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/version_item.mm View 1 chunk +76 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/cells/version_item_unittest.mm View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm View 1 chunk +900 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm View 1 chunk +306 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm View 1 chunk +63 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/content_settings_collection_view_controller.h View 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm View 1 chunk +211 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm View 1 chunk +46 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/contextual_search_collection_view_controller.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/contextual_search_collection_view_controller.mm View 1 chunk +216 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/contextual_search_collection_view_controller_unittest.mm View 1 chunk +71 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller.mm View 1 chunk +167 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/dataplan_usage_collection_view_controller_unittest.mm View 1 chunk +114 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm View 1 chunk +196 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/do_not_track_collection_view_controller_unittest.mm View 1 chunk +74 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/handoff_collection_view_controller.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm View 1 chunk +160 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/import_data_collection_view_controller.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm View 1 chunk +195 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/settings/import_data_collection_view_controller_unittest.mm View 1 chunk +178 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-19 14:01:25 UTC) #4
rohitrao (ping after 24h)
lgtm!
4 years ago (2016-12-19 14:08:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589583003/1
4 years ago (2016-12-19 14:15:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 14:22:39 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-19 14:24:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceea172d0994ae358ff2c562efbedfd897faa182
Cr-Commit-Position: refs/heads/master@{#439469}

Powered by Google App Engine
This is Rietveld 408576698