Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2589493007: CrOS - Fix position of notification bubble for lock screen. (Closed)

Created:
4 years ago by Evan Stade
Modified:
4 years ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS - Fix position of notification bubble for lock screen. In this case the alignment enum value is SHELF_ALIGNMENT_BOTTOM_LOCKED. BUG=666625 Committed: https://crrev.com/8522fd00254ba2e136b89f60efb0bb6da4b7b707 Cr-Commit-Position: refs/heads/master@{#439577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
4 years ago (2016-12-19 20:48:36 UTC) #2
Daniel Erat
lgtm (was going to ask for a test, but it looks like there aren't any ...
4 years ago (2016-12-19 20:59:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589493007/1
4 years ago (2016-12-19 21:02:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 21:44:16 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-19 21:47:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8522fd00254ba2e136b89f60efb0bb6da4b7b707
Cr-Commit-Position: refs/heads/master@{#439577}

Powered by Google App Engine
This is Rietveld 408576698