Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2589493004: Files app: Handle chrome.runtime.lastError for chrome.storage API calls. (Closed)

Created:
4 years ago by fukino
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Files app: Handle chrome.runtime.lastError for chrome.storage API calls. BUG=671080, 674434 TEST=manually tested by modifying chrome.storage API to return errors and confirming that Files app works properly with default options. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2578863003 Cr-Commit-Position: refs/heads/master@{#438806} (cherry picked from commit 26defffaca3b257fae0f625d04fc14724fc71682) Committed: https://chromium.googlesource.com/chromium/src/+/e8abe66c74b57ced730aa2977f93fdd59d7c4c72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M ui/file_manager/file_manager/common/js/util.js View 1 chunk +5 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/app_state_controller.js View 3 chunks +17 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/banners.js View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
4 years ago (2016-12-19 08:22:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8abe66c74b57ced730aa2977f93fdd59d7c4c72.

Powered by Google App Engine
This is Rietveld 408576698