Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2589403002: Make DOMWindowProperty::frameDestroyed non-virtual (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DOMWindowProperty::frameDestroyed non-virtual Now no one is overriding DOMWindowProperty::frameDestroyed. BUG=610176 Committed: https://crrev.com/fb7b0b4e2d9af73d8bec28b9f39fecfb4906a350 Cr-Commit-Position: refs/heads/master@{#440070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/frame/DOMWindowProperty.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
4 years ago (2016-12-21 08:47:05 UTC) #2
sof
lgtm
4 years ago (2016-12-21 09:05:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589403002/1
4 years ago (2016-12-21 09:06:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 10:49:28 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 10:51:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7b0b4e2d9af73d8bec28b9f39fecfb4906a350
Cr-Commit-Position: refs/heads/master@{#440070}

Powered by Google App Engine
This is Rietveld 408576698