Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7287)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 25894003: Don't write URLs to clipboard from views omnibox as hyperlinks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/bookmark_node_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index 9f39b0e20e701743e6be1448a399f816ec0bf3dc..0be5695781ad8781d17c68bcc9c12326a14402e2 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -1614,11 +1614,10 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CopyURLToClipboard) {
EXPECT_TRUE(clipboard->IsFormatAvailable(
ui::Clipboard::GetPlainTextFormatType(), ui::Clipboard::BUFFER_STANDARD));
- // The Mac is the only platform which doesn't write html.
-#if !defined(OS_MACOSX)
- EXPECT_TRUE(clipboard->IsFormatAvailable(
+ // Make sure HTML format isn't written. See
+ // BookmarkNodeData::WriteToClipboard() for details.
+ EXPECT_FALSE(clipboard->IsFormatAvailable(
ui::Clipboard::GetHtmlFormatType(), ui::Clipboard::BUFFER_STANDARD));
-#endif
// These platforms should read bookmark format.
#if defined(OS_WIN) || defined(OS_CHROMEOS) || defined(OS_MACOSX)
@@ -1661,11 +1660,10 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CutURLToClipboard) {
EXPECT_TRUE(clipboard->IsFormatAvailable(
ui::Clipboard::GetPlainTextFormatType(), ui::Clipboard::BUFFER_STANDARD));
- // The Mac is the only platform which doesn't write html.
-#if !defined(OS_MACOSX)
- EXPECT_TRUE(clipboard->IsFormatAvailable(
+ // Make sure HTML format isn't written. See
+ // BookmarkNodeData::WriteToClipboard() for details.
+ EXPECT_FALSE(clipboard->IsFormatAvailable(
ui::Clipboard::GetHtmlFormatType(), ui::Clipboard::BUFFER_STANDARD));
-#endif
// These platforms should read bookmark format.
#if defined(OS_WIN) || defined(OS_CHROMEOS) || defined(OS_MACOSX)
« no previous file with comments | « chrome/browser/bookmarks/bookmark_node_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698