Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3974)

Unified Diff: chrome/browser/bookmarks/bookmark_node_data.cc

Issue 25894003: Don't write URLs to clipboard from views omnibox as hyperlinks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_node_data.cc
diff --git a/chrome/browser/bookmarks/bookmark_node_data.cc b/chrome/browser/bookmarks/bookmark_node_data.cc
index b1d201fa709f01562dcfae409646c967ef29a49f..524f6c334a1ad161cd8dc501afe7e6250e798eeb 100644
--- a/chrome/browser/bookmarks/bookmark_node_data.cc
+++ b/chrome/browser/bookmarks/bookmark_node_data.cc
@@ -143,7 +143,10 @@ void BookmarkNodeData::WriteToClipboard() const {
const std::string url = elements[0].url.spec();
scw.WriteBookmark(title, url);
- scw.WriteHyperlink(title, url);
+
+ // Don't call scw.WriteHyperlink() here, since some rich text editors will
+ // change fonts when such data is pasted in; besides, most such editors
+ // auto-linkify at some point anyway.
// Also write the URL to the clipboard as text so that it can be pasted
// into text fields. We use WriteText instead of WriteURL because we don't
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698